Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't apply selector to link-to in helper form #314

Closed
allthesignals opened this issue Feb 4, 2019 · 2 comments
Closed

Can't apply selector to link-to in helper form #314

allthesignals opened this issue Feb 4, 2019 · 2 comments

Comments

@allthesignals
Copy link

I can't seem to apply a test selector to the inline form of link-to:

{{link-to 'Features' 'features' data-test-header-features-link="features"}}

link-to, a component, appears to be using positional params. According to docs, this should work:

{{link-to data-test-header-features-link 'Features' 'features'}}

This throws:

Error: Assertion Failed: You attempted to define a {{link-to "Features"}} but did not pass the parameters required for generating its dynamic segments. There is no route named Features

I've tried it a few other ways with no luck. It seems to just either not show or throw some error about a missing route (because it's trying to use data-test as an input).

I'm on Ember 3.6. How do most people use test selectors for links?

@Turbo87
Copy link
Collaborator

Turbo87 commented Feb 5, 2019

@allthesignals I've tried to reproduce your problem but it seems to be working fine for me. I've opened a PR to add a test case for link-to components to our test suite (#315) and that also seems to be working fine 🤔

@allthesignals
Copy link
Author

Woops! I made a silly mistake. Sorry to waste your time @Turbo87!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants