Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible mistake in documentation of data-attribute? #20

Closed
Fryie opened this issue Aug 24, 2016 · 1 comment · Fixed by #21
Closed

Possible mistake in documentation of data-attribute? #20

Fryie opened this issue Aug 24, 2016 · 1 comment · Fixed by #21

Comments

@Fryie
Copy link
Contributor

Fryie commented Aug 24, 2016 •
edited
Loading

In this section, we first introduce data-test-selector="post-title", but in the next example this becomes data-test-post-title. Is this a leftover from an older version (which I think it is, judging from the change history) or am I missing some piece?

I can make a PR for it, but I just wanted to make sure I'm not mistaken first.
@pangratz
Copy link
Contributor

Good catch! A PR is very welcome!

Can you also update the sentence in this section from … makes sure to remove all these data attributes in the … to … makes sure to remove all these data-test-* attributes in the …

Cheers.

@Fryie Fryie mentioned this issue Aug 24, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix documentation
2 participants
@pangratz @Fryie