Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add smoke tests #13

Closed
pangratz opened this issue Mar 29, 2016 · 5 comments
Closed

Add smoke tests #13

pangratz opened this issue Mar 29, 2016 · 5 comments

Comments

@pangratz
Copy link
Contributor

using ember-cli-addon-tests

@marcoow
Copy link
Member

marcoow commented Mar 29, 2016

👍

Am 28.03.2016 um 22:54 schrieb Clemens Müller [email protected]:

using ember-cli-addon-tests


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub

@Turbo87
Copy link
Collaborator

Turbo87 commented Jan 9, 2017

@pangratz do the existing tests now qualify as smoke tests?

@pangratz
Copy link
Contributor Author

@Turbo87 what I meant back then with the exceptional descriptive "add smoke tests" were tests, which check that the result of ember build doesn't contain data-test-* anymore in the templates (and in JS too if #10 is done).

I guess it's related to #28.

Feel free to close this one in favour of #28.

@Turbo87
Copy link
Collaborator

Turbo87 commented Jan 10, 2017

@pangratz well, right now we're not stripping everything out, so the tests you describe would always fail. I'd propose to implement those tests in the PR that finally strips out all the things.

@marcoow
Copy link
Member

marcoow commented Jan 11, 2017

Closing this as we have pretty good coverage now

@marcoow marcoow closed this as completed Jan 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants