Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I still see test selectors in production files #118

Closed
dossorio opened this issue Jun 15, 2017 · 1 comment · Fixed by #128
Closed

I still see test selectors in production files #118

dossorio opened this issue Jun 15, 2017 · 1 comment · Fixed by #128
Labels

Comments

@dossorio
Copy link

Hi ! first of all thanks for the great addon! It makes testing markup agnostic which is something I love! <3

I had a look to the production build though, and I could still see some test selectors in there, so I put together this repo so you can reproduce the issue.

Steps to reproduce:

  • Run ember build --prod
  • Have a look in the files that were generated, you will be able to see the data-test-component there

Is this intended ? I was expecting the test selector not to be there right ?

Thanks !

@marcoow
Copy link
Member

marcoow commented Jun 26, 2017

I confirmed the test selector is still present. Any idea @Turbo87 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants