Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treasury Log Export: incorrect dates for dates earlier than the relative (pseudo-) dates #3164

Open
kleopatra opened this issue Jan 22, 2025 · 3 comments
Labels
Bug Next Version Issue will be dealt with in the next update

Comments

@kleopatra
Copy link

we started a discussion on discord but as the improvement now is part of the release notes, it might be time for a real bug report :)

Problem is the date/time field of the treasury log: it's a pseudo/relative date (like "yesterday at 7:00 pm", or "on Thursday at 11:00 am") for the last six/seven days, and more like a "real" date (like "on 1/15/25 at 11:59") for older entries. The entries are localized, the example is for beta.

Image

The conversion of the pseudo date/time entries are working fine, but the older dates are incorrect, note

  • the jump forward in date from 16 -> 19, it should be 16 -> 15
  • the incorrect time part (which might be a different issue, am/pm -> military time seems to be wrong on other dates as well, just saw it but didn't dig)

16.1.2025 12:00:00
19.1.2025 11:59:00

Similar issue for German server (minus the time-related issue):

Image

16.1.2025 02:17:00
19.1.2025 23:20:00

@Beelzebob6666
Copy link
Collaborator

thanks - fixed in beta

@Beelzebob6666 Beelzebob6666 added Bug Next Version Issue will be dealt with in the next update labels Jan 22, 2025
@kleopatra
Copy link
Author

kleopatra commented Jan 31, 2025

date looks okay now, thanks!

Time part (am/pm -> 24hr format conversion) is still wrong (beta server, probably all locales with am/pm). Details (decided to do it here, you can c&p to a new issue if you prefer, want to get it off my desk ;)

The original log, A is at midnight, B at midnight + 1h:

A:
Image

B:
Image

Expected conversion in export:

A:
00:01
23:58

B:
01:23
00:26

Actual output in export:

A:
12:01:00
11:58:00

B:
13:23:00
12:26:00

The output looks really weird, like either a mixture of am/pm and 24hr or somewhat offset by 12/24 hrs sometimes. Have seen times like 23:xx - will check at which actual log times they are.

Okay, here are the details, screenshots of the log C is noon, D is noon + 1hr

C:

Image

D:

Image

Expected output in export:

C:
12:00
11:46

D:
13:07
12:22

Actual output in export:

C:
12:00:00
23:46:00

D:
01:07:00
12:22:00

@Beelzebob6666
Copy link
Collaborator

fixed thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Next Version Issue will be dealt with in the next update
Projects
None yet
Development

No branches or pull requests

2 participants