Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error message mentions API key even if using access token #49

Closed
1 task done
dkotter opened this issue Aug 19, 2024 · 0 comments · Fixed by #50
Closed
1 task done

Error message mentions API key even if using access token #49

dkotter opened this issue Aug 19, 2024 · 0 comments · Fixed by #50
Assignees
Milestone

Comments

@dkotter
Copy link
Collaborator

dkotter commented Aug 19, 2024

Describe the bug

This is a minor thing but noticed that if you connect via the new OAuth flow but then the access token becomes invalid for some reason, we show an error message on the settings page (different from the error admin notice).

This error message says the API key may be invalid, even if someone isn't using an API key at all (which will be the case for all new users once the OAuth feature ships).

Would be great to update that error message, either making it more generic (something like authentication failed instead of mentioning API key or access token) or modify the error message depending on if someone has an API key or access token set.

Steps to Reproduce

  1. Authenticate via the new OAuth flow
  2. In the database, modify the mailchimp_sf_access_token value to make it invalid
  3. Refresh the settings page to see the error message

Screenshots, screen recording, code snippet

Error message

Environment information

No response

WordPress information

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants