-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove jquery dependencies #49
Comments
@lduh to be specific on what this particular error was - the public javascript that we have had been dependent on jQuery until I made that change... but all it did was basically look for the email fields on the form and when the user focuses in on that field it submits it so we can track it. I feel like this change I made will solve that, but if i'm being honest, we should probably even start considering browser testing too to see if this javascript is valid across all browsers. UGH. :) |
Couldnt test actual issue, but have regression tested around this change and everything seems good. |
Hi, I am getting a strange jQuery issue on my website https://pxadventures.co.uk/store which only seems to appear when I have this plugin running. I have tested disabling plugins to try and find the cause, and while I doubt that this is an issue directly with your plugin, I am at a loss to work out why with your plugin enabled, the issue occurs. Basically, on some page loads (not all, which further confuses me!), https://pxadventures.co.uk/jquery.js is called but returns a 404 error as it does not exist. Usually, a refresh resolves it, but when my site is so dependant on jQuery for the search box (in the header), the mobile navigation, the product filters and pagination on my checkout page, I have had the MailChimp plugin disabled to ensure that we aren't affected by this. However, given that I pay for MailChimp and want to use it, I really need to try and work out what is the actual cause of this. Given this ticket and the Gravity Forms Conflict ticket from before, it looks like a similar issue has cropped up in the past, but it looks like it shouldn't be affecting my site now. Please could you shed any light on where I should look to resolve this? I shall leave the plugin running for now, so a visit to my site with devtools should show the issue. I am happy to provide admin access to my site if it helps Many Thanks, Here is my WooCommerce Status Report: ` WordPress EnvironmentWordPress address (URL): https://pxadventures.co.uk Server EnvironmentServer Info: LiteSpeed SUHOSIN Installed: – DatabaseWC Database Version: 3.6.2 Post Type Countsattachment: 11034 SecuritySecure connection (HTTPS): ✔ Active Plugins (55)PXA AffiliateWP Extension: by George Laing - PX Hosting – 1.0 AffiliateWP - Affiliate Info: by AffiliateWP AffiliateWP - Allow Own Referrals: by AffiliateWP AffiliateWP Mailchimp Add-on: by Tunbosun Ayinla – 1.2.0 SearchWP Live Ajax Search: by Jonathan Christopher – 1.3.1 SearchWP Term Highlight: by Jonathan Christopher – 2.1.13 SearchWP: by SearchWP Page Builder by SiteOrigin: by SiteOrigin – 2.10.5 Inactive Plugins (12)Akismet Anti-Spam: by Automattic – 4.1.2 Dropin Plugins (2)advanced-cache.php: advanced-cache.php SettingsAPI Enabled: ✔ Taxonomies: Product Visibility: exclude-from-catalog (exclude-from-catalog) Connected to WooCommerce.com: ✔ WC PagesShop base: #9 - /store/ ThemeName: OceanWP Child TemplatesOverrides: oceanwp/woocommerce/cart/mini-cart.php WooCommerce Google Product Feed fieldsProduct description: Variation description only Availability: Defaults to "in stock". WooCommerce Google Product Feed optionsInclude variations in feed: Enabled Action SchedulerComplete: 895 Pending: 2 Canceled: 0 In-progress: 0 Failed: 0 ` |
@glaing This one is outside the scope of our plugin. We're only piggybacking off of jquery when you're in the admin area. The front end JS doesn't use it at all. You've got a lot of plugins activated on this site, and I've also navigated to your site just now and it looks like that jQuery file is being hosted on a CDN. Maybe you've got something going on with the CDN, or even possibly a load balancer issue that needs to be looked at. Sorry we can't really do too much about this, as we need to keep the plugin in context for everything we're doing. If you can somehow show us that it's the plugin's fault, we'll of course look into that for you. Thanks! |
Hi Ryan, You were spot on - disabling my CDN resolved the problem initially. Thanks for the pointer! Thanks, |
Good to hear @glaing thanks for reporting back. |
@ciaobeau @lduh @khungate just pushed up a fix that removed the need for jquery... which should probably solve that guys issue that was causing trouble.
The text was updated successfully, but these errors were encountered: