Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove jquery dependencies #49

Closed
ryanhungate opened this issue Oct 5, 2016 · 6 comments
Closed

remove jquery dependencies #49

ryanhungate opened this issue Oct 5, 2016 · 6 comments
Labels
Milestone

Comments

@ryanhungate
Copy link
Collaborator

@ciaobeau @lduh @khungate just pushed up a fix that removed the need for jquery... which should probably solve that guys issue that was causing trouble.

@ryanhungate
Copy link
Collaborator Author

@lduh to be specific on what this particular error was - the public javascript that we have had been dependent on jQuery until I made that change... but all it did was basically look for the email fields on the form and when the user focuses in on that field it submits it so we can track it. I feel like this change I made will solve that, but if i'm being honest, we should probably even start considering browser testing too to see if this javascript is valid across all browsers. UGH. :)

@lduh
Copy link
Contributor

lduh commented Oct 6, 2016

Couldnt test actual issue, but have regression tested around this change and everything seems good.

@glaing
Copy link

glaing commented May 16, 2019

Hi,

I am getting a strange jQuery issue on my website https://pxadventures.co.uk/store which only seems to appear when I have this plugin running.

I have tested disabling plugins to try and find the cause, and while I doubt that this is an issue directly with your plugin, I am at a loss to work out why with your plugin enabled, the issue occurs.

Basically, on some page loads (not all, which further confuses me!), https://pxadventures.co.uk/jquery.js is called but returns a 404 error as it does not exist.

Usually, a refresh resolves it, but when my site is so dependant on jQuery for the search box (in the header), the mobile navigation, the product filters and pagination on my checkout page, I have had the MailChimp plugin disabled to ensure that we aren't affected by this. However, given that I pay for MailChimp and want to use it, I really need to try and work out what is the actual cause of this.

Given this ticket and the Gravity Forms Conflict ticket from before, it looks like a similar issue has cropped up in the past, but it looks like it shouldn't be affecting my site now.

Please could you shed any light on where I should look to resolve this? I shall leave the plugin running for now, so a visit to my site with devtools should show the issue. I am happy to provide admin access to my site if it helps

Many Thanks,
George

Here is my WooCommerce Status Report:

`

WordPress Environment

WordPress address (URL): https://pxadventures.co.uk
Site address (URL): https://pxadventures.co.uk
WC Version: 3.6.2
Log Directory Writable: ✔
WP Version: ❌ 4.9.10 - There is a newer version of WordPress available (5.2)
WP Multisite: –
WP Memory Limit: 2 GB
WP Debug Mode: ✔
WP Cron: –
Language: en_GB
External object cache: ✔

Server Environment

Server Info: LiteSpeed
PHP Version: 7.2.18
PHP Post Max Size: 1 GB
PHP Time Limit: 3600
PHP Max Input Vars: 10000
cURL Version: 7.62.0
OpenSSL/1.0.2k

SUHOSIN Installed: –
MySQL Version: 10.1.38-MariaDB-cll-lve
Max Upload Size: 512 MB
Default Timezone is UTC: ✔
fsockopen/cURL: ✔
SoapClient: ✔
DOMDocument: ✔
GZip: ✔
Multibyte String: ✔
Remote Post: ✔
Remote Get: ✔

Database

WC Database Version: 3.6.2
WC Database Prefix: pxwp_
Total Database Size: 679.84MB
Database Data Size: 518.55MB
Database Index Size: 161.29MB
pxwp_woocommerce_sessions: Data: 9.02MB + Index: 0.14MB
pxwp_woocommerce_api_keys: Data: 0.02MB + Index: 0.03MB
pxwp_woocommerce_attribute_taxonomies: Data: 0.02MB + Index: 0.02MB
pxwp_woocommerce_downloadable_product_permissions: Data: 0.02MB + Index: 0.05MB
pxwp_woocommerce_order_items: Data: 1.52MB + Index: 0.36MB
pxwp_woocommerce_order_itemmeta: Data: 10.52MB + Index: 8.03MB
pxwp_woocommerce_tax_rates: Data: 0.02MB + Index: 0.06MB
pxwp_woocommerce_tax_rate_locations: Data: 0.02MB + Index: 0.05MB
pxwp_woocommerce_shipping_zones: Data: 0.00MB + Index: 0.00MB
pxwp_woocommerce_shipping_zone_locations: Data: 0.00MB + Index: 0.01MB
pxwp_woocommerce_shipping_zone_methods: Data: 0.00MB + Index: 0.00MB
pxwp_woocommerce_payment_tokens: Data: 0.00MB + Index: 0.00MB
pxwp_woocommerce_payment_tokenmeta: Data: 0.01MB + Index: 0.02MB
pxwp_woocommerce_log: Data: 0.00MB + Index: 0.00MB
pxwp_affiliate_wp_affiliatemeta: Data: 0.02MB + Index: 0.03MB
pxwp_affiliate_wp_affiliates: Data: 0.02MB + Index: 0.02MB
pxwp_affiliate_wp_creatives: Data: 0.02MB + Index: 0.02MB
pxwp_affiliate_wp_customermeta: Data: 0.00MB + Index: 0.01MB
pxwp_affiliate_wp_customers: Data: 0.00MB + Index: 0.01MB
pxwp_affiliate_wp_payouts: Data: 0.00MB + Index: 0.00MB
pxwp_affiliate_wp_referrals: Data: 0.02MB + Index: 0.02MB
pxwp_affiliate_wp_rest_consumers: Data: 0.00MB + Index: 0.00MB
pxwp_affiliate_wp_visits: Data: 0.02MB + Index: 0.02MB
pxwp_commentmeta: Data: 0.05MB + Index: 0.03MB
pxwp_comments: Data: 3.52MB + Index: 3.16MB
pxwp_failed_jobs: Data: 0.01MB + Index: 0.00MB
pxwp_links: Data: 0.02MB + Index: 0.02MB
pxwp_litespeed_img_optm: Data: 159.77MB + Index: 29.39MB
pxwp_litespeed_optimizer: Data: 29.42MB + Index: 0.45MB
pxwp_mailchimp_carts: Data: 0.28MB + Index: 0.00MB
pxwp_mc4wp_log: Data: 0.02MB + Index: 0.00MB
pxwp_options: Data: 59.39MB + Index: 3.47MB
pxwp_postmeta: Data: 156.67MB + Index: 77.23MB
pxwp_posts: Data: 32.53MB + Index: 8.48MB
pxwp_pxa_xeroconnector_inventory: Data: 1.56MB + Index: 0.16MB
pxwp_pxa_xeroconnector_inventory_ordering: Data: 0.01MB + Index: 0.01MB
pxwp_pxa_xeroconnector_inventory_purchase_orders: Data: 0.00MB + Index: 0.01MB
pxwp_pxa_xeroconnector_settings: Data: 0.00MB + Index: 0.01MB
pxwp_pxa_xeroconnector_stocksync: Data: 0.78MB + Index: 0.10MB
pxwp_pxa_xeroconnector_stocksync_gtin_issues: Data: 0.10MB + Index: 0.02MB
pxwp_pxa_xeroconnector_stocksync_potentialproducts: Data: 0.16MB + Index: 0.02MB
pxwp_pxa_xeroconnector_suppliers: Data: 0.00MB + Index: 0.01MB
pxwp_pxa_xeroconnector_tracked_returns: Data: 0.00MB + Index: 0.01MB
pxwp_queue: Data: 0.40MB + Index: 0.01MB
pxwp_revslider_css: Data: 0.13MB + Index: 0.00MB
pxwp_revslider_layer_animations: Data: 0.02MB + Index: 0.00MB
pxwp_revslider_navigations: Data: 0.02MB + Index: 0.00MB
pxwp_revslider_sliders: Data: 0.02MB + Index: 0.00MB
pxwp_revslider_slides: Data: 0.02MB + Index: 0.00MB
pxwp_revslider_static_slides: Data: 0.02MB + Index: 0.00MB
pxwp_swp_cf: Data: 0.36MB + Index: 0.29MB
pxwp_swp_index: Data: 15.95MB + Index: 10.25MB
pxwp_swp_log: Data: 0.66MB + Index: 0.64MB
pxwp_swp_tax: Data: 1.09MB + Index: 0.81MB
pxwp_swp_terms: Data: 0.83MB + Index: 1.12MB
pxwp_termmeta: Data: 1.38MB + Index: 1.38MB
pxwp_terms: Data: 1.52MB + Index: 3.03MB
pxwp_term_relationships: Data: 3.52MB + Index: 3.52MB
pxwp_term_taxonomy: Data: 2.48MB + Index: 2.94MB
pxwp_usermeta: Data: 1.52MB + Index: 2.02MB
pxwp_users: Data: 0.08MB + Index: 0.05MB
pxwp_wcpdf_invoice_number: Data: 0.00MB + Index: 0.00MB
pxwp_wc_booking_relationships: Data: 0.00MB + Index: 0.00MB
pxwp_wc_download_log: Data: 0.00MB + Index: 0.00MB
pxwp_wc_gpf_render_cache: Data: 0.00MB + Index: 0.00MB
pxwp_wc_product_meta_lookup: Data: 1.23MB + Index: 1.24MB
pxwp_wc_webhooks: Data: 0.00MB + Index: 0.00MB
pxwp_wfBlockedIPLog: Data: 0.02MB + Index: 0.01MB
pxwp_wfBlocks7: Data: 0.02MB + Index: 0.01MB
pxwp_wfConfig: Data: 1.43MB + Index: 0.01MB
pxwp_wfCrawlers: Data: 0.01MB + Index: 0.01MB
pxwp_wfFileChanges: Data: 0.00MB + Index: 0.00MB
pxwp_wfFileMods: Data: 1.71MB + Index: 0.35MB
pxwp_wfHits: Data: 4.95MB + Index: 1.00MB
pxwp_wfHoover: Data: 0.00MB + Index: 0.00MB
pxwp_wfIssues: Data: 0.05MB + Index: 0.01MB
pxwp_wfKnownFileList: Data: 0.89MB + Index: 0.11MB
pxwp_wfLiveTrafficHuman: Data: 0.01MB + Index: 0.02MB
pxwp_wfLocs: Data: 0.01MB + Index: 0.00MB
pxwp_wfLogins: Data: 0.19MB + Index: 0.04MB
pxwp_wfls_2fa_secrets: Data: 0.02MB + Index: 0.02MB
pxwp_wfls_settings: Data: 0.02MB + Index: 0.00MB
pxwp_wfNotifications: Data: 0.00MB + Index: 0.00MB
pxwp_wfPendingIssues: Data: 0.00MB + Index: 0.00MB
pxwp_wfReverseCache: Data: 0.01MB + Index: 0.00MB
pxwp_wfSNIPCache: Data: 0.00MB + Index: 0.00MB
pxwp_wfStatus: Data: 0.14MB + Index: 0.05MB
pxwp_wfTrafficRates: Data: 0.00MB + Index: 0.00MB
pxwp_woocommerce_barclaycardcw_customer_contexts: Data: 0.02MB + Index: 0.02MB
pxwp_woocommerce_barclaycardcw_documents: Data: 0.02MB + Index: 0.02MB
pxwp_woocommerce_barclaycardcw_ecc: Data: 1.02MB + Index: 0.00MB
pxwp_woocommerce_barclaycardcw_schema_version: Data: 0.02MB + Index: 0.02MB
pxwp_woocommerce_barclaycardcw_storage: Data: 0.02MB + Index: 0.02MB
pxwp_woocommerce_barclaycardcw_transactions: Data: 7.52MB + Index: 0.00MB
pxwp_woocommerce_gpf_google_taxonomy: Data: 2.02MB + Index: 0.00MB
pxwp_wsal_metadata: Data: 0.13MB + Index: 0.05MB
pxwp_wsal_occurrences: Data: 0.01MB + Index: 0.01MB
pxwp_wsal_options: Data: 0.00MB + Index: 0.00MB
pxwp_yoast_seo_links: Data: 1.06MB + Index: 0.29MB
pxwp_yoast_seo_meta: Data: 0.42MB + Index: 0.44MB

Post Type Counts

attachment: 11034
behind-the-scenes: 2
bookable_resource: 1
bts_blog: 1
customize_changeset: 2
custom_css: 1
feedback: 12
global_product_addon: 2
mc4wp-form: 2
ml-slide: 82
ml-slider: 34
nav_menu_item: 107
news: 16
oembed_cache: 8
page: 138
portfolio: 1
post: 58
postman_sent_mail: 250
product: 4911
product_variation: 10898
revision: 295
safecss: 1
scheduled-action: 897
shopping-cart: 1
shop_coupon: 181
shop_order: 4835
shop_order_refund: 102
sidebar: 14
size-guide: 36
staff: 7
testimonial: 1
wpcf7_contact_form: 3
ywtm_tab: 3

Security

Secure connection (HTTPS): ✔
Hide errors from visitors: ✔

Active Plugins (55)

PXA AffiliateWP Extension: by George Laing - PX Hosting – 1.0
PXA Content Management System: by George Laing - PX Hosting – 0.0.1
PXA OSM Badge Shopping List Importer: by George Laing - PX Hosting – 1.1.0
PXA Order Fulfilment System: by George Laing - PX Hosting – 2.0
PXA Purchase Order: by George Laing - PX Hosting – 1.0
PXA SearchWP Extension: by George Laing - PX Hosting – 1.0
PXA WC POS Extention: by George Laing - PX Hosting – 0.0.1
PXA WooCommerce Extension: by George Laing - PX Hosting – 1.0 – Not tested with the active version of WooCommerce
PXA Xero Connector: by George Laing - PX Hosting – 1.0.0 – Not tested with the active version of WooCommerce
AffiliateWP: by AffiliateWP
LLC – 2.2.16

AffiliateWP - Affiliate Info: by AffiliateWP
LLC – 1.0.5

AffiliateWP - Allow Own Referrals: by AffiliateWP
LLC – 1.0.2

AffiliateWP Mailchimp Add-on: by Tunbosun Ayinla – 1.2.0
AMP: by AMP Project Contributors – 1.1.1
Google Tag Manager for Wordpress: by Thomas Geiger – 1.9.2 – Not tested with the active version of WooCommerce
Elementor: by Elementor.com – 2.5.15
Facebook for WooCommerce: by Facebook – 1.9.10 – Not tested with the active version of WooCommerce
Glue for Yoast SEO & AMP: by Joost de Valk – 0.4.3
Intercom: by Intercom – 2.6.1
LiteSpeed Cache: by LiteSpeed Technologies – 2.9.7.2
Mailchimp for WooCommerce: by Mailchimp – 2.1.16 – Not tested with the active version of WooCommerce
MetaSlider: by Team Updraft – 3.13.1
Ocean Cookie Notice: by OceanWP – 1.0.4
Ocean Extra: by OceanWP – 1.5.5
Ocean Hooks: by OceanWP – 1.1.2
Ocean Popup Login: by OceanWP – 1.0.5
Ocean Sticky Header: by OceanWP – 1.1.11
Ocean Woo Popup: by OceanWP – 1.0.6
Post SMTP: by Yehuda Hassine – 2.0.1
Reading Time WP: by Jason Yingling – 2.0.4
Regenerate Thumbnails: by Alex Mills (Viper007Bond) – 3.1.1
SearchWP Fuzzy Matches: by SearchWP
LLC – 1.4.3

SearchWP Live Ajax Search: by Jonathan Christopher – 1.3.1
SearchWP Related: by SearchWP
LLC – 1.0.4

SearchWP Term Highlight: by Jonathan Christopher – 2.1.13
SearchWP Term Synonyms: by SearchWP
LLC – 2.4.13

SearchWP: by SearchWP
LLC – 2.9.12

Page Builder by SiteOrigin: by SiteOrigin – 2.10.5
SiteOrigin Widgets Bundle: by SiteOrigin – 1.15.6
Trustpilot-reviews: by Trustpilot – 2.5.695 – Not tested with the active version of WooCommerce
WooCommerce Variation Structured Data - Option 3: by Lee Willis – 0.2 – Not tested with the active version of WooCommerce
WooCommerce Extended Coupon Features FREE: by Soft79 – 3.0.5 – Not tested with the active version of WooCommerce
WooCommerce Composite Products: by SomewhereWarm – 3.13.7 – Not tested with the active version of WooCommerce
WooCommerce Stripe Gateway: by WooCommerce – 4.1.16
WooCommerce MSRP Pricing: by Lee Willis – 2.9.5 – Not tested with the active version of WooCommerce
WooCommerce POS: by kilbot – 0.4.23
WooCommerce Product Add-ons: by WooCommerce – 2.9.2 – Not tested with the active version of WooCommerce
WooCommerce Google Product Feed: by Ademti Software Ltd. – 7.8.6
WooCommerce Xero Integration: by WooCommerce – 1.7.10 – Not tested with the active version of WooCommerce
WooCommerce: by Automattic – 3.6.2
Wordfence Security: by Wordfence – 7.3.1
Yoast SEO Premium: by Team Yoast – 7.2
WP Crontrol: by John Blackbourn & contributors – 1.7.1
WP reCaptcha Integration: by Jörn Lund – 1.2.1
Yoast SEO: WooCommerce: by Team Yoast – 5.8 – Not tested with the active version of WooCommerce

Inactive Plugins (12)

Akismet Anti-Spam: by Automattic – 4.1.2
Beans: by Beans – 3.0.2 – Not tested with the active version of WooCommerce
Contact Form 7: by Takayuki Miyoshi – 5.1.1
Download Attachments: by dFactory – 1.2.23
MailChimp Cleanup Tool: by George Laing - PX Hosting – 1.0.0 – Not tested with the active version of WooCommerce
Ocean Instagram: by OceanWP – 1.0.3
Query Monitor: by John Blackbourn – 3.3.5
SearchWP LIKE Terms: by Jonathan Christopher – 2.4.4.1
Under Construction: by WebFactory Ltd – 3.40
WooCommerce Accommodation Bookings: by WooCommerce – 1.1.5 – Not tested with the active version of WooCommerce
WooCommerce BarclaycardCw: by customweb GmbH – 4.0.138 – Not tested with the active version of WooCommerce
WooCommerce Bookings: by Automattic – 1.11.1 – Not tested with the active version of WooCommerce

Dropin Plugins (2)

advanced-cache.php: advanced-cache.php
object-cache.php: object-cache.php

Settings

API Enabled: ✔
Force SSL: –
Currency: GBP (£)
Currency Position: left
Thousand Separator: ,
Decimal Separator: .
Number of Decimals: 2
Taxonomies: Product Types: booking (booking)
composite (composite)
external (external)
grouped (grouped)
simple (simple)
variable (variable)

Taxonomies: Product Visibility: exclude-from-catalog (exclude-from-catalog)
exclude-from-search (exclude-from-search)
featured (featured)
outofstock (outofstock)
rated-1 (rated-1)
rated-2 (rated-2)
rated-3 (rated-3)
rated-4 (rated-4)
rated-5 (rated-5)

Connected to WooCommerce.com: ✔

WC Pages

Shop base: #9 - /store/
Basket: #10 - /basket/
Checkout: #11 - /checkout/
My account: #12 - /my-account/
Terms and conditions: #2942 - /our-story/our-policies/

Theme

Name: OceanWP Child
Version: 1.0
Author URL: https://oceanwp.org/
Child Theme: ✔
Parent Theme Name: OceanWP
Parent Theme Version: 1.6.7
Parent Theme Author URL: https://oceanwp.org/about-me/
WooCommerce Support: ✔

Templates

Overrides: oceanwp/woocommerce/cart/mini-cart.php
oceanwp/woocommerce/content-single-product.php
oceanwp-child-theme-master/woocommerce/emails/admin-new-order.php
oceanwp-child-theme-master/woocommerce/emails/customer-completed-order.php
oceanwp-child-theme-master/woocommerce/emails/customer-processing-order.php
oceanwp-child-theme-master/woocommerce/emails/email-footer.php
oceanwp-child-theme-master/woocommerce/emails/email-header.php
oceanwp-child-theme-master/woocommerce/emails/email-styles.php
oceanwp/woocommerce/loop/loop-start.php
oceanwp/woocommerce/single-product/title.php

WooCommerce Google Product Feed fields

Product description: Variation description only
fallback to main description (full preferred).

Availability: Defaults to "in stock".
Bundle indicator (is_bundle):
Condition: Defaults to "new".
Brand: Pre-populates from pa_brand taxonomy.
Manufacturer Part Number (MPN): Pre-populates from pa_mpn taxonomy.
Product Type: Pre-populates from pa_product_category taxonomy.
Google Product Category:
Global Trade Item Number (GTIN): Pre-populates from GTIN meta field.
Gender: Defaults to "unisex".
Age Group: Defaults to "adult".
Colour: Pre-populates from pa_colour taxonomy.
Size: Pre-populates from pa_size taxonomy.
Size type: Defaults to "regular".
Size system: Defaults to "UK".
Material:
Pattern: Pre-populates from pa_colour taxonomy.
Adult content: Defaults to "no".
Bing Category: Pre-populates from pa_product_category taxonomy.
Delivery label: Defaults to "UK Shipping".
Minimum handling time: Defaults to "1".
Maximum handling time: Defaults to "10".
Custom label 0:
Custom label 1:

WooCommerce Google Product Feed options

Include variations in feed: Enabled
Send item_group_id: Enabled

Action Scheduler

Complete: 895
Oldest: 2019-04-15 22:05:04 +0100
Newest: 2019-05-16 17:10:04 +0100

Pending: 2
Oldest: 2019-05-22 09:25:06 +0100
Newest: 2019-05-22 09:25:06 +0100

Canceled: 0
Oldest: –
Newest: –

In-progress: 0
Oldest: –
Newest: –

Failed: 0
Oldest: –
Newest: –

`

@ryanhungate
Copy link
Collaborator Author

@glaing This one is outside the scope of our plugin. We're only piggybacking off of jquery when you're in the admin area. The front end JS doesn't use it at all. You've got a lot of plugins activated on this site, and I've also navigated to your site just now and it looks like that jQuery file is being hosted on a CDN.

Maybe you've got something going on with the CDN, or even possibly a load balancer issue that needs to be looked at. Sorry we can't really do too much about this, as we need to keep the plugin in context for everything we're doing. If you can somehow show us that it's the plugin's fault, we'll of course look into that for you.

Thanks!

@glaing
Copy link

glaing commented Jun 18, 2019

Hi Ryan,

You were spot on - disabling my CDN resolved the problem initially. Thanks for the pointer!

Thanks,
George

@ryanhungate
Copy link
Collaborator Author

Good to hear @glaing thanks for reporting back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants