Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error messaging for missing Address #20

Closed
lduh opened this issue Sep 14, 2016 · 4 comments
Closed

Better error messaging for missing Address #20

lduh opened this issue Sep 14, 2016 · 4 comments
Labels

Comments

@lduh
Copy link
Contributor

lduh commented Sep 14, 2016

https://cl.ly/1z1A0C023y0x

During setup - If the user doesn't include all the necessary address information, it doesn't save. (But it still displays the "Settings Saved" feedback) We need to inform the user WHY we aren't accepting their changes, and highlight the required fields.

Something like:

As part of the MailChimp Terms of Use, we require that a contact email and a physical mailing address.

(adapted from http://kb.mailchimp.com/lists/growth/about-the-required-email-footer-content)

@ryanhungate
Copy link
Collaborator

@lduh just pushed up a fix for this... give it a go!

@lduh
Copy link
Contributor Author

lduh commented Sep 16, 2016

I'm a dummy. @ryanhungate can we edit to

As part of the MailChimp Terms of Use, we require a contact email and a physical mailing address.

@ryanhungate
Copy link
Collaborator

@lduh yeah sorry I didn't even proofread that before copying it in.

@lduh
Copy link
Contributor Author

lduh commented Sep 26, 2016

looks good: https://cl.ly/0H29293L1g1y

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants