Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename binaries in line with autonomi branding #2471

Merged
merged 1 commit into from
Dec 1, 2024

Conversation

jacderida
Copy link
Contributor

The following binaries were renamed:

  • safenode -> antnode
  • safenode-manager -> antctl
  • safenode_rpc_client -> antnode_rpc_client

As part of the PR I took the opportunity to do other things.

BREAKING CHANGE: the data directories for the binaries are changed to use autonomi in their path rather than safe.

Operations for the node manager's auditor and faucet subcommands were changed to panic. The whole subcommands should be removed later.

The Protobuf definitions were changed from Safe -> Ant.

Removed the faucet feature from the node manager.

As many code references as possible to safenode or similar, were changed.

)?;

Ok(())
// TODO: The whole subcommand for the auditor should be removed when we have some time.

Check notice

Code scanning / devskim

A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note

Suspicious comment
Err(eyre!("Upgrade failed: {e}"))
}
}
// TODO: The whole subcommand for the auditor should be removed when we have some time.

Check notice

Code scanning / devskim

A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note

Suspicious comment
)?;

Ok(())
// TODO: The whole subcommand for the auditor should be removed when we have some time.

Check notice

Code scanning / devskim

A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note

Suspicious comment
}
Err(e) => Err(eyre!("Upgrade failed: {e}")),
}
// TODO: The whole subcommand for the auditor should be removed when we have some time.

Check notice

Code scanning / devskim

A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note

Suspicious comment
@jacderida jacderida force-pushed the chore-rename_binaries branch 4 times, most recently from 901674c to 8538114 Compare December 1, 2024 21:29
The following binaries were renamed:
* `safenode` -> `antnode`
* `safenode-manager` -> `antctl`
* `safenode_rpc_client` -> `antnode_rpc_client`

As part of the PR I took the opportunity to do other things.

BREAKING CHANGE: the data directories for the binaries are changed to use `autonomi` in their path
rather than `safe`.

Operations for the node manager's `auditor` and `faucet` subcommands were changed to panic. The
whole subcommands should be removed later.

The Protobuf definitions were changed from `Safe` -> `Ant`.

Removed the `faucet` feature from the node manager.

As many code references as possible to `safenode` or similar, were changed.
@jacderida jacderida force-pushed the chore-rename_binaries branch from 8538114 to 212c8fa Compare December 1, 2024 21:56
@jacderida jacderida merged commit 16b2e62 into maidsafe:main Dec 1, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant