feat(sn_networking): use wasm compatible retry #2387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| }) | ||
| }).await | ||
| // FIXME: Skip if we get a permanent error during verification, e.g., DoubleSpendAttempt |
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
Previously the `backoff` crate was used which is not compatible with wasm and futures (though the docs suggest there is compatibility, but that seems to be without futures). The retry strategy is adjusted, but I have attempted to keep the end result similar if not the same.
b-zee
force-pushed
the
feat-wasm-compatible-retry
branch
from
75ab499 to
d772c52
Compare
maqi
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the
backoffcrate was used which is not compatible with wasm and futures (though the docs suggest there is compatibility, but that seems to be without futures).The retry strategy is adjusted, but I have attempted to keep the end result similar if not the same.