Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: add vault CLI testcases #2345

Merged
merged 3 commits into from
Nov 4, 2024
Merged

tests: add vault CLI testcases #2345

merged 3 commits into from
Nov 4, 2024

Conversation

ermineJose
Copy link
Contributor

@ermineJose ermineJose commented Oct 28, 2024 •
edited
Loading

Description

Adds functional test cases to Autonomi Vault CLI utility

Related Issue

Fixes #<issue_number> (if applicable).

Type of Change

Please mark the types of changes made in this pull request.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Checklist

Please ensure all of the following tasks have been completed:

  • I have read the contributing guidelines.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have updated the documentation accordingly.
  • I have followed the conventional commits guidelines for commit messages.
  • I have verified my commit messages with commitlint.

@ermineJose ermineJose force-pushed the tests_cli-vault branch 17 times, most recently from 7fb32d7 to c947285 Compare October 29, 2024 17:43
@ermineJose ermineJose force-pushed the tests_cli-vault branch 2 times, most recently from b410565 to a1d6d3c Compare October 30, 2024 13:45
@ermineJose ermineJose force-pushed the tests_cli-vault branch 9 times, most recently from 766443e to 928a340 Compare November 4, 2024 05:15
@ermineJose ermineJose requested a review from grumbach November 4, 2024 09:03
grumbach
grumbach approved these changes Nov 4, 2024
View reviewed changes
Copy link
Member

@grumbach grumbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ermineJose ermineJose added this pull request to the merge queue Nov 4, 2024
Merged via the queue into main with commit 2e1e278 Nov 4, 2024
28 checks passed
@ermineJose ermineJose deleted the tests_cli-vault branch November 4, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grumbach grumbach grumbach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ermineJose @grumbach