Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(autonomi): minor clarifications #2328

Merged
merged 1 commit into from
Oct 29, 2024
Merged

chore(autonomi): minor clarifications #2328

merged 1 commit into from
Oct 29, 2024

Conversation

loziniak
Copy link
Contributor

Description

Noticed some discrepancies during work with autonomi crate.

Type of Change

Please mark the types of changes made in this pull request.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe): chore

Checklist

Please ensure all of the following tasks have been completed:

  • I have read the contributing guidelines.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have updated the documentation accordingly.
  • I have followed the conventional commits guidelines for commit messages.
  • I have verified my commit messages with commitlint.

@b-zee b-zee enabled auto-merge October 29, 2024 07:04
@b-zee
Copy link
Contributor

b-zee commented Oct 29, 2024

Thanks a lot @loziniak. Your changes make total sense 🙇

@b-zee b-zee added this pull request to the merge queue Oct 29, 2024
github-merge-queue bot pushed a commit that referenced this pull request Oct 29, 2024
chore(autonomi): minor clarifications
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 29, 2024
@maqi maqi added this pull request to the merge queue Oct 29, 2024
Merged via the queue into maidsafe:main with commit 17febdc Oct 29, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants