Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(launchpad): launchpad wallet integration follow up #2304

Merged
merged 5 commits into from
Oct 23, 2024
Merged

chore(launchpad): launchpad wallet integration follow up #2304

merged 5 commits into from
Oct 23, 2024

Conversation

mazzi
Copy link
Contributor

@mazzi mazzi commented Oct 23, 2024 •
edited
Loading

Follow up PR to #2278

Should be merged into main when the RC gets merged there.

DONE

  • Rename of variables, structs, constants, to replace discord username for wallet address.
  • Remove rejectTandC popup screen.

What's left:

  • Replace validation?
  • Use another field name to store rewards address

@mazzi mazzi changed the base branch from main to hotfix-2024.10.3.3 October 23, 2024 15:06
@mazzi mazzi mentioned this pull request Oct 23, 2024
Closed
@mazzi mazzi requested review from jacderida and RolandSherwin and removed request for jacderida October 23, 2024 15:07
@jacderida jacderida merged commit d5ba1d3 into maidsafe:hotfix-2024.10.3.3 Oct 23, 2024
24 of 26 checks passed
@mazzi mazzi deleted the lp_wallet_follow_up branch October 24, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacderida jacderida jacderida approved these changes

@RolandSherwin RolandSherwin Awaiting requested review from RolandSherwin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mazzi @jacderida