give contract infinite token allowance #2275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ct approval to infinite
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| ) | ||
| .await | ||
| .map_err(|err| PayForQuotesError(Error::from(err), tx_hashes_by_quote.clone()))?; | ||
|
|
||
| // TODO: Get rid of approvals altogether, by using permits or whatever.. |
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
b-zee
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of approving the data payments contract to spend what is needed, we now let it spend as much as it wants. Obviously, this is a security concern and should not be the final behaviour. We should look into permits or another solution instead.
For now it will severely reduce problems with concurrent wallet transactions and reduce the amount of transactions needed for data payments.
The problem we had with approvals is that concurrent data payments would overwrite each other's approved allowance, resulting in data payment failures.