leverage get_range more #2259
Merged
leverage get_range more #2259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuef
changed the title
joshuef
force-pushed
the
Feat-CloseInRange
branch
from
5098d26 to
ce31563
Compare
joshuef
force-pushed
the
Feat-CloseInRange
branch
from
ce31563 to
a83e156
Compare
maqi
approved these changes
Oct 17, 2024
sn_networking/src/lib.rs
Outdated
| } | ||
|
|
||
| debug!( | ||
| "Network knowledge of closest peers in range of {key:?} are: {:?}", |
There was a problem hiding this comment.
the log better to be :
Network knowledge of closest peers in range of {:?} to target {key:?} are: {:?}, expected_range.log2(), restricted_closest_peers.len()
This should allow us to return more peers for various network operations, and leverage range based gets more frequently
joshuef
force-pushed
the
Feat-CloseInRange
branch
from
a83e156 to
44f1f87
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.