Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(manager): provide option to specify node ip #2130

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

RolandSherwin
Copy link
Member

  • the safenode manager now supports specifying the ip address to listen on

@RolandSherwin RolandSherwin force-pushed the safenode_manager_ip branch 2 times, most recently from 29aa367 to 0b4d8d9 Compare September 19, 2024 15:45
eq(ServiceInstallCtx {
args: vec![
OsString::from("--rpc"),
OsString::from("127.0.0.1:12001"),

Check notice

Code scanning / devskim

Accessing localhost could indicate debug code, or could hinder scaling. Note test

Do not leave debug code in production
eq(ServiceInstallCtx {
args: vec![
OsString::from("--rpc"),
OsString::from("127.0.0.1:8081"),

Check notice

Code scanning / devskim

Accessing localhost could indicate debug code, or could hinder scaling. Note

Do not leave debug code in production
@jacderida jacderida enabled auto-merge September 19, 2024 16:05
@jacderida jacderida added this pull request to the merge queue Sep 19, 2024
Merged via the queue into maidsafe:main with commit bda1bc4 Sep 19, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants