feat: client API first iteration #2093
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
devskim found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
b-zee
force-pushed
the
feat-client-api-skeleton
branch
from
bdafe04 to
297c14c
Compare
b-zee
force-pushed
the
feat-client-api-skeleton
branch
2 times, most recently
from
5bb7fd2 to
23dc3c2
Compare
b-zee
force-pushed
the
feat-client-api-skeleton
branch
from
f7dccb5 to
d2e3984
Compare
| let StoragePaymentResult { skipped_chunks, .. } = | ||
| self.pay(xor_names.into_iter(), wallet).await?; | ||
|
|
||
| // TODO: Upload in parallel |
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
| for content_addr in content_addrs { | ||
| let network = self.network.clone(); | ||
| tasks.spawn(async move { | ||
| // TODO: retry, but where? |
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
|
|
||
| let addr = client.put(data, wallet).await?; | ||
|
|
||
| // TODO: Set created_at and modified_at |
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
| } | ||
|
|
||
| fn build_client_and_run_swarm(local: bool) -> (Network, Receiver<NetworkEvent>) { | ||
| // TODO: `root_dir` is only used for nodes. `NetworkBuilder` should not require it. |
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
| let root_dir = std::env::temp_dir(); | ||
| let network_builder = NetworkBuilder::new(Keypair::generate_ed25519(), local, root_dir); | ||
|
|
||
| // TODO: Re-export `Receiver<T>` from `sn_networking`. Else users need to keep their `tokio` dependency in sync. |
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
| let network_builder = NetworkBuilder::new(Keypair::generate_ed25519(), local, root_dir); | ||
|
|
||
| // TODO: Re-export `Receiver<T>` from `sn_networking`. Else users need to keep their `tokio` dependency in sync. | ||
| // TODO: Think about handling the mDNS error here. |
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
| } | ||
| } | ||
|
|
||
| // TODO: Handle closing of network events sender |
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
| } | ||
| } | ||
|
|
||
| // TODO: as WASM can not save a wallet state to disk or load from disk -- we need to provide a wallet state manually. |
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
| .insert(spend); | ||
| } | ||
|
|
||
| // TODO: should we verify if the transfer is valid and destined for this wallet? |
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
There was a problem hiding this comment.
the test compile needs fixed eg https://github.com/maidsafe/safe_network/actions/runs/10791386235/job/29928681734?pr=2093
but once thats in gtg!
Initial implementation of high level API