-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(launchpad): connection mode and fixes #2076
Conversation
80599af
to
6a9c131
Compare
retry_count = 0; // Reset retry count on success | ||
} | ||
Err(err) => { | ||
//TODO: We should use concrete error types here instead of string matching (sn_node_manager) |
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on mac, code looks good! Nice one @mazzi
Although I dont understand how to get to the port popup there 🤔
Thanks!
When |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aha, with the above, I cannot save my custom port range. Hitting enter does nothing for me 🤔
Most likely your port range is out of a valid one. |
6485c94
to
49d7248
Compare
I think that your claim is valid as you didn't know this screen beforehand. We added feedback to the user in case that the port range is invalid 👍 |
Implemented feedback to the user to understand why "enter doesn nothing".
49d7248
to
c3b3d56
Compare
Description
Options
screen calledConnection Mode
, were the user can switch betweenAutomatic
,Home Network
,UPnP
,Custom Ports
.A technical overview
NAT detection
Now we use the latest
nat-detection
crate oncrates.io
. Thanks to a bug fixed on sn-releases.Error Handling
A new module was created to show error messages on popups. Can be plugged on any component. Documentation on the file.
Port Popup
It is a separate popup, in opposition to the established strategy in
Drive Selection
andBeta Programme
, were follow up popups are self contained on the same file. The reason for this is that we can invoke thePort Selection
popup directly from theOptions
screen.Node mgmt
A couple of refactors there were we created helper functions to be able to understand better the algorithm.
Bug fixes
The application will run despite
app_config.json
doesn't have certain keys related to mountpoints.Dependencies
Updated
sn-releases
to0.2.8
.Testing
Desktop testing was made. Mostly on macOS. We will need to test more on Windows/Linux.
Screenshots
|