Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(launchpad): node actions #2444

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

mazzi
Copy link
Contributor

@mazzi mazzi commented Nov 14, 2024

Description

Internal crates

  • Changes on node-manager to be less verbose (Verbosity::Minimal on calls)

Main feature

  • Now we can start/stop, add, remove individual nodes. For this we implemented a locking mechanism (semaphore) per node (locked on NodeItem). It's set to true before starting a NodeManagementTask and false when succeeds or returns with error. There are some helper functions for that effect.

Validation

  • Validations when adding nodes ([+]) regarding the maximum amount of nodes and available disk space. Some helpers were created for the error messages.
  • Validation of some edge cases like operations without nodes, when the application starts from scratch.
  • New popup screen when trying to remove ([-]) a node. Gives a warning.

Styling

  • Changed footer style and behavior depending on the application state. Now is sort of flexible when shrinking the terminal (minimal resolution 80x24).

Extras

  • Some minor error message formatting.
  • Changed the legend when upgrading nodes as is difficult to pass the amount of nodes between scenes. Instead of calculating total time of upgrade, we just mention how much takes per node.

Bug fix 🐞

  • We added CONNECTION_TIMEOUT_START as a constant. We were using a hardcoded value as timeout when starting nodes that was making few RPC connection attempts and failing too early.

🛑 Do not merge straight away so we squash and merge.

@mazzi mazzi requested a review from RolandSherwin November 14, 2024 16:35
node-launchpad/src/components/status.rs Dismissed Show dismissed Hide dismissed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant