Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Internal crates
node-manager
to be less verbose (Verbosity::Minimal
on calls)Main feature
locked
onNodeItem
). It's set totrue
before starting aNodeManagementTask
andfalse
when succeeds or returns with error. There are some helper functions for that effect.Validation
[+]
) regarding the maximum amount of nodes and available disk space. Some helpers were created for the error messages.[-]
) a node. Gives a warning.Styling
Extras
Bug fix 🐞
CONNECTION_TIMEOUT_START
as a constant. We were using a hardcoded value as timeout when starting nodes that was making few RPC connection attempts and failing too early.🛑 Do not merge straight away so we squash and merge.