Spend and range atop main #2033
Conversation
BREAKING CHANGE
BREAKING CHANGE: many types gone, replaced by UnsignedTransaction SignedTransaction
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| let mapped: Vec<_> = sorted_distances.iter().map(|d| d.ilog2()).collect(); | ||
| info!("Sorted distances: {:?}", mapped); | ||
|
|
||
| // TODO: Test this calculation in larger networks |
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
| .await | ||
| { | ||
| Ok(record) => record, | ||
| // TODO: do we need to handle SplitRecord anywhere else? |
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
|
|
||
| let bytes = try_serialize_record(&spends, RecordKind::Spend)?; | ||
|
|
||
| // TODO: does this need merged with any local copy? |
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
| // info!("{id} verifying status of spend number({num:?}): {spend:?} : {status:?}"); | ||
| // match status { | ||
| // SpendStatus::Utxo => { | ||
| // // TODO: with the new spend struct requiring `middle payment` |
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note test
joshuef
force-pushed
the
SpendAndRangeAtopMain
branch
from
bc0afa2 to
0962caf
Compare
| @@ -389,6 +395,7 @@ | |||
| .set_max_packet_size(MAX_PACKET_SIZE) | |||
| // Require iterative queries to use disjoint paths for increased resiliency in the presence of potentially adversarial nodes. | |||
| .disjoint_query_paths(true) | |||
| // TODO: Do we want to reduce this from default still? | |||
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
| info!("RANGE: {pretty_key:?} we_have_searched_far_enough: {we_have_searched_thoroughly:?}"); | ||
|
|
||
| let result = if num_of_versions > 1 { | ||
| // TODO: Do we want to repopulate a split record.and under what conditions? |
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
| @@ -476,25 +503,34 @@ | |||
| let mut replication_fetcher = ReplicationFetcher::new(peer_id, event_sender); | |||
|
|
|||
| // Set distance range | |||
| // TODO: close peers can break the distance range check here... we need a proper | |||
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
|
closing to replace with just the getrange work atop this |
#1989 and #2011 atop latest main codebase.