fix(publisher-github): replace special characters in the asset name

ISSUES CLOSED: electron#1759
mahnunchik · Dec 18, 2020 · 96cb015 · 96cb015
1 parent 4824af6
commit 96cb015
Showing 1 changed file with 9 additions and 2 deletions.
diff --git a/packages/publisher/github/src/PublisherGithub.ts b/packages/publisher/github/src/PublisherGithub.ts
@@ -99,7 +99,14 @@ export default class PublisherGithub extends PublisherBase<PublisherGitHubConfig
             uploaded += 1;
             updateSpinner();
           };
-          const artifactName = path.basename(artifactPath);
+          // Based on https://developer.github.com/v3/repos/releases/#upload-a-release-asset and
+          // https://stackoverflow.com/questions/59081778/rules-for-special-characters-in-github-repository-name
+          const artifactName = path.basename(artifactPath)
+            .replace(/\s/g, '.')
+            .replace(/\.+/g, '.')
+            .replace(/^\./g, '')
+            .replace(/\.$/g, '')
+            .replace(/[^\w.-]/g, '-');
           // eslint-disable-next-line max-len
           if (release!.assets.find((asset: OctokitReleaseAsset) => asset.name === artifactName)) {
             return done();
@@ -115,7 +122,7 @@ export default class PublisherGithub extends PublisherBase<PublisherGitHubConfig
               'content-type': mime.lookup(artifactPath) || 'application/octet-stream',
               'content-length': (await fs.stat(artifactPath)).size,
             },
-            name: path.basename(artifactPath),
+            name: artifactName,
           });
           return done();
         }));