Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug(writeComments): Changes comments if \ is included #54

Closed
doxsch opened this issue Mar 16, 2021 · 4 comments · Fixed by #55
Closed

Bug(writeComments): Changes comments if \ is included #54

doxsch opened this issue Mar 16, 2021 · 4 comments · Fixed by #55

Comments

@doxsch
Copy link
Contributor

doxsch commented Mar 16, 2021

When reading comments \ are loaded correctly, but when writing they are then replaced by \\. This leads to wrong comments when writing and reading multiple times.

I assume that it is not necessary to encode the comments.
@doxsch doxsch mentioned this issue Mar 16, 2021
Merged
@doxsch
Copy link
Contributor Author

doxsch commented Mar 23, 2021 •
edited
Loading

Hi @magiconair

Thanks for merging my changes. Would it be possible to release a new version (v1.8.5)?

Best regards

@magiconair
Copy link
Owner

Fixing tests for older versions now. Then I'll tag. Version parsing was not quite right.

@magiconair
Copy link
Owner

Tagged.

@doxsch
Copy link
Contributor Author

doxsch commented Mar 25, 2021

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: Encoding Bug in Comments doxsch/properties
2 participants
@magiconair @doxsch