Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚡ Align partial sign with Web3.js #11

Merged
merged 1 commit into from
Sep 25, 2022
Merged

Conversation

GabrielePicco
Copy link
Contributor

Align partial sign with Web3.js version, including fix from the original Solnet codebase

⚠️ NOTE: Use notes like this to emphasize something important about the PR.

This could include other PRs this PR is built on top of; API breaking changes; reasons for why the PR is on hold; or anything else you would like to draw attention to.

Status Type ⚠️ Core Change
Ready Bug No

Problem

Partial signature was not aligned with Web3.js

Align partial sign with Web3.js version, including fix from the original Solnet codebase
@coveralls
Copy link

coveralls commented Sep 25, 2022

Pull Request Test Coverage Report for Build 3121218885

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 21 of 22 (95.45%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.04%) to 80.875%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Solana.Unity.Rpc/Builders/MessageBuilder.cs 10 11 90.91%
Totals Coverage Status
Change from base Build 3119685259: -0.04%
Covered Lines: 6544
Relevant Lines: 7841

💛 - Coveralls

@GabrielePicco GabrielePicco merged commit 9cd1137 into master Sep 25, 2022
@GabrielePicco GabrielePicco deleted the fix-partial-sign branch September 25, 2022 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants