From 755978397a8d0bacbfe81f7240b1e3ff3b9b23af Mon Sep 17 00:00:00 2001 From: Amit Bera Date: Sun, 7 Jan 2018 12:17:58 +0530 Subject: [PATCH 1/3] Newsletter Model Subcriber LoadByEmail does not - Use MYSQL index - Add an Mysql Index key via upgrade Schema - files add at app/code/Magento/Newsletter/Setup/UpgradeScheme.php - Modified at app/code/Magento/Newsletter/etc/module.xml --- .../Newsletter/Setup/UpgradeSchema.php | 37 +++++++++++++++++++ app/code/Magento/Newsletter/etc/module.xml | 2 +- 2 files changed, 38 insertions(+), 1 deletion(-) create mode 100644 app/code/Magento/Newsletter/Setup/UpgradeSchema.php diff --git a/app/code/Magento/Newsletter/Setup/UpgradeSchema.php b/app/code/Magento/Newsletter/Setup/UpgradeSchema.php new file mode 100644 index 0000000000000..4edd5f4ac9b8a --- /dev/null +++ b/app/code/Magento/Newsletter/Setup/UpgradeSchema.php @@ -0,0 +1,37 @@ +startSetup(); + + if (version_compare($context->getVersion(), '2.0.1', '<')) { + $connection = $setup->getConnection(); + + $connection->addIndex( + $setup->getTable('newsletter_subscriber'), + $setup->getIdxName('newsletter_subscriber', ['subscriber_email']), + ['subscriber_email'] + ); + } + + $setup->endSetup(); + } +} \ No newline at end of file diff --git a/app/code/Magento/Newsletter/etc/module.xml b/app/code/Magento/Newsletter/etc/module.xml index f338445225222..5da16a9a3e9ba 100644 --- a/app/code/Magento/Newsletter/etc/module.xml +++ b/app/code/Magento/Newsletter/etc/module.xml @@ -6,7 +6,7 @@ */ --> - + From b85349745c4a593306edf61dae2235cd96a0fcd2 Mon Sep 17 00:00:00 2001 From: Amit Bera Date: Sun, 7 Jan 2018 13:47:14 +0530 Subject: [PATCH 2/3] Fixing the code style issue. #12787 --- .../Magento/Newsletter/Setup/UpgradeSchema.php | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/app/code/Magento/Newsletter/Setup/UpgradeSchema.php b/app/code/Magento/Newsletter/Setup/UpgradeSchema.php index 4edd5f4ac9b8a..783d8dcc80447 100644 --- a/app/code/Magento/Newsletter/Setup/UpgradeSchema.php +++ b/app/code/Magento/Newsletter/Setup/UpgradeSchema.php @@ -1,22 +1,21 @@ endSetup(); } -} \ No newline at end of file +} From be8b258b6a7ff406f099619c917e2001731f1157 Mon Sep 17 00:00:00 2001 From: David Manners Date: Sun, 7 Jan 2018 14:11:50 +0530 Subject: [PATCH 3/3] Remove extra white-space from before the UpgradeSchemaInterface --- app/code/Magento/Newsletter/Setup/UpgradeSchema.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/code/Magento/Newsletter/Setup/UpgradeSchema.php b/app/code/Magento/Newsletter/Setup/UpgradeSchema.php index 783d8dcc80447..e7ce898de83a3 100644 --- a/app/code/Magento/Newsletter/Setup/UpgradeSchema.php +++ b/app/code/Magento/Newsletter/Setup/UpgradeSchema.php @@ -12,7 +12,7 @@ /** * Upgrade the Newsletter module DB scheme */ -class UpgradeSchema implements UpgradeSchemaInterface +class UpgradeSchema implements UpgradeSchemaInterface { /** * {@inheritdoc}