Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

different backup download links on backups page all point to the same file/url of the last backup #5968

Closed
nldudok1 opened this issue Aug 3, 2016 · 6 comments
Assignees
Labels
bug report Fixed in 2.3.x The issue has been fixed in 2.3 release line help wanted Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release

Comments

@nldudok1
Copy link

nldudok1 commented Aug 3, 2016

When you make multiple backups they all show up on the backups page. They all have a clickable link so you can download the backup file. Each link should be unique and point to that specific backup. But all links are the same and all point only to the last backup.

Preconditions

  1. Magento 2.1.0 freshinstall Magento-CE-2.1.0-2016-06-23-02-28-50.tar.bz2
  2. PHP 5.6.23-0+deb8u1 (cli) (built: Jul 12 2016 07:33:16)
  3. Apache 2.4
  4. debian 8.5
  5. mysql --version
    mysql Ver 15.1 Distrib 10.0.25-MariaDB, for debian-linux-gnu (x86_64) using readline 5.2

Steps to reproduce

  1. Go to System/backup
  2. Create a system backup
  3. Create a database backup
  4. Create another database backup
    Now you should have three unique backups. But the .tgz and .sql links on each line all point to the last backup, which is in this case a .sql file of the second database backup.

Expected result

  1. All links should be unique and result in downloading the backup you selected.

Actual result

  1. See screenshots. In the first screenshot I hover over the .tgz link of the last backup. See the url at the bottom of the screenshot. In screenshot 2, I hover over the .tgz link of the second backup. See that the url is the same. In screenshot 3 you see that when I click the .tgz link, I actually download the .sql file of the last backup. (EDIT: I now see that the screenshot did not actually show the url in the bottombar, so you will just have to try yourself)
    screenshot magento backup link 1 from 2016-08-03 18 30 34
    screenshot magento backup link 2 from 2016-08-03 18 30 55
    screenshot magento backup link download from 2016-08-03 18 31 28

[Screenshot, logs]

@Sergeacc
Copy link

@nldudok1 Thanks for reporting this issue, internal ticket was created MAGETWO-70384.

@veloraven veloraven added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Jul 3, 2017
@magento-engcom-team magento-engcom-team added bug report Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed labels Sep 11, 2017
@magento-engcom-team
Copy link
Contributor

@nldudok1, thank you for your report.
The issue is already fixed in develop branch
But we will consider to backport the fix to patch releases

@magento-engcom-team magento-engcom-team added 2.1.x Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release labels Oct 6, 2017
@Mobecls Mobecls self-assigned this Dec 15, 2017
@Mobecls
Copy link
Contributor

Mobecls commented Dec 15, 2017

#mageconf

@dmanners
Copy link
Contributor

dmanners commented May 3, 2018

Since this has been fixed in 2.3-develop with the pr #10593 this ticket would just require someone to backport and test this fix on 2.1 and 2.2 versions.

@stetoc stetoc self-assigned this May 12, 2018
@stetoc
Copy link

stetoc commented May 12, 2018

I tried to reproduce error on 2.2, tried various combinations and everything looks fine, looks like error is not a thing anymore. Each download url is pointing to different file, every database dump is containing valid data reflecting real database state before backup.

@sidolov
Copy link
Contributor

sidolov commented Jun 11, 2018

Issue has been fixed in scope of #11595

@sidolov sidolov closed this as completed Jun 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report Fixed in 2.3.x The issue has been fixed in 2.3 release line help wanted Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release
Projects
None yet
Development

No branches or pull requests

9 participants