-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invalid PHP 8 Notation in PHP 7.4 code #37935
Comments
Hi @floshontay. Thank you for your report.
Join Magento Community Engineering Slack and ask your questions in #github channel. |
Hi @engcom-Bravo. Thank you for working on this issue.
|
There must have been some confusion, I'm trying to reproduce it and I'll let you know, if I can actually do that. Until then I close the issue. |
OK it is definitely reproducible from 2.4.4-p2 upgrading to 2.4.4-p5 running composer with php7.4! |
Hello @floshontay I closed this issue due to reason described above. |
Wait a second. This is right from 2.4.4-p6 composer.json:
If you don't want your project to be compatible with a specific PHP version you should not add that kind of constraint. |
Preconditions and environment
Steps to reproduce
when running
with PHP 7.4 there is also PHP 8 syntax fetched.
in
vendor/paypal/module-braintree-core/Gateway/Command/GetPaymentNonceCommand.php
there is the line
public function execute(array $commandSubject): ArrayResult|ResultInterface|null
which results in an exception if you run the application with PHP 7.4
Expected result
The application should run
Actual result
You always get an exception because of invalid syntax
Additional information
No response
Release note
No response
Triage and priority
The text was updated successfully, but these errors were encountered: