Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Severity: S1] Default consumer configurations prevents consumers running with Cron. #35446

Closed
tschirmer opened this issue May 9, 2022 · 9 comments
Assignees
Labels
Issue: needs update Additional information is require, waiting for response Reported on 2.4.4 Indicates original Magento version for the Issue report. Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it

Comments

@tschirmer
Copy link

tschirmer commented May 9, 2022

Preconditions (*)

  1. Install Magento 2.4.4

Steps to reproduce (*)

  1. install Magento, remove all reference to consumers from env.php and config.php

Expected result (*)

  1. All consumers should be run with cron.

Actual result (*)

  1. No consumers are run with cron.

According to documentation here: https://devdocs.magento.com/guides/v2.4/config-guide/mq/manage-message-queues.html

image

consumers - An array of strings specifying which consumer(s) to run. An empty array runs all consumers.

but if we look at the consumers runner here:

$allowedConsumers = $this->deploymentConfig->get('cron_consumers_runner/consumers', []);

The default value for allowed consumers is an empty array. No consumers get run if the configuration is empty.

@m2-assistant
Copy link

m2-assistant bot commented May 9, 2022

Hi @tschirmer. Thank you for your report.
To speed up processing of this issue, make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, review the Magento Contributor Assistant documentation.

Add a comment to assign the issue: @magento I am working on this

To learn more about issue processing workflow, refer to the Code Contributions.


⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@engcom-Delta engcom-Delta added the Reported on 2.4.4 Indicates original Magento version for the Issue report. label May 9, 2022
@engcom-Delta engcom-Delta self-assigned this May 9, 2022
@m2-assistant
Copy link

m2-assistant bot commented May 9, 2022

Hi @engcom-Delta. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@tschirmer
Copy link
Author

I've continued to look through this code, and there is a line that's meant to achieve this:

if (!empty($allowedConsumers) && !in_array($consumerName, $allowedConsumers)) {

We've had an issue with inventory not marking the product out of stock after reaching 0 saleable qty. We've tracked it to the consumers not running, and until we added the consumer into the config.php / env.php the problem persisted. We're still experiencing the consumers not running unless explicitly specified on 2.4.4

@LucianMihalache
Copy link

@magento give me 2.4-develop instance

@magento-deployment-service
Copy link

Hi @LucianMihalache. Thank you for your request. I'm working on Magento instance for you.

@magento-deployment-service
Copy link

@engcom-Delta engcom-Delta removed their assignment May 10, 2022
@engcom-Hotel engcom-Hotel added the Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it label Jun 30, 2022
@engcom-Echo
Copy link
Contributor

Hello @tschirmer,

Thank you for reporting the issue.

We tried to reproduce it on Magento 2.4-dev but the issue is not reproducible.

Steps followed to reproduce issue:

1- Install the fresh Magento 2.4-dev instance.
2- Remove all reference to consumers from env.php and config.php
3- Place order of a product which has 1 quantity remaining.
4- Order is placed
5- Product becomes Out Of Stock after reaching 0

Would be helpful if you could provide the exact steps you followed with a screenshot like checking queues of consumers, any additional steps if you opted facing this issue etc so we can try to reproduce the same at our end.

@engcom-Echo engcom-Echo added the Issue: needs update Additional information is require, waiting for response label Jul 20, 2022
@m2-assistant
Copy link

m2-assistant bot commented Jul 29, 2022

Hi @engcom-Echo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

    1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
      DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.
    1. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.
    1. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
    1. Verify that the issue is reproducible on 2.4-develop branch
      Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
      - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
      - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

@engcom-Echo
Copy link
Contributor

Hello @tschirmer,

We have noticed that this issue has not been updated for a period of 14 Days.
Hence we assume that this issue is fixed now, so we are closing it.Please raise a fresh ticket or reopen this ticket if you need more assistance on this.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: needs update Additional information is require, waiting for response Reported on 2.4.4 Indicates original Magento version for the Issue report. Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it
Projects
None yet
Development

No branches or pull requests

5 participants