Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check codebase compatibility with PHP 8.1 using unit tests #34377

Closed
github-jira-sync-bot opened this issue Oct 18, 2021 · 4 comments
Closed
Labels
Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Project: Platform Health

Comments

@github-jira-sync-bot
Copy link

In order to better understand scope of changes required for PHP8.1 support in magento we need to run static check\tests

 

To Do

  • Use latest available PHP8.1 build or docker image with required extensions
  • Include Inventory, PageBuilder, SecurityPackage, Adobe Stock, Adobe IMS
  • Add PHP8.1 to root composer.json (for tests only. Not need to be delivered)
  • Attempt to install dependencies using latest composer 1.x and 2.x
    • use dev-master for php-amqplib/php-amqplib if version with PHP8.1 support is not available
  • try to run all unit tests (or module by module)
  • Report detected issues
@github-jira-sync-bot github-jira-sync-bot added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: ready for dev labels Oct 18, 2021
@github-jira-sync-bot
Copy link
Author

The issue was exported from the internal Jira. The link to the original Jira issue: https://jira.corp.magento.com/browse/AC-1516

@m2-assistant
Copy link

m2-assistant bot commented Oct 18, 2021

Hi @github-jira-sync-bot. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this


⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@xmav
Copy link
Contributor

xmav commented Oct 18, 2021

depends on
#34374
#34356

@andrewbess
Copy link

All steps have been finished
Issues have been created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Project: Platform Health
Projects
None yet
Development

No branches or pull requests

3 participants