Update magento2 codebase to be compatible with PHP 8

[sivaschenko]

Description 

Add PHP 8 compatibility to Magento 2

What should be done

1. Fix the areas not yet covered by PHPCompatibility on develop branch:
   Account for changes introduced in PHP 8.0 PHPCompatibility/PHPCompatibility#809
2. Update PHP version in composer.json from "7.3.0||7.4.0" to "7.4.0||8.0.0"
3. Fix failed tests with PHP 8

Apply fro the following repos:

• < > https://github.com/magento/magento2
• < > https://github.com/magento/partners-magento2ee
• < > https://github.com/magento/partners-magento2b2b
• < > https://github.com/magento/partners-magento2-infrastructure

 

[m2-assistant]

Hi @sivaschenko. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[jamescowie]

Going to use this ticket as the tracker for what issues I faced and resolved.

Currently working on resolveArgument with $enforcedArguments being the wrong type. Within ClassReader reflection resolved the deprecated code of getType with getName

[jamescowie]

For composer and package manager we need to upgrade "laminas/laminas-mvc": "3.1.*", however that version conflicts which then stops installation of additional packages

[sivaschenko]

@jamescowie great idea, It could be really helpful if you share the issues you faced, however, it could be even more helpful if these issues could be described in a bit more details. Unfortunately, I don't really understand which resolveArgument and $enforcedArguments you are talking about.

Also, this issue is related to the Magento codebase only, there are separate issues created for dependencies versions

[sergeynezbritskiy]

@sivaschenko I've ran the next command vendor/bin/phpcs -p --standard=PhpCompatibility --extensions=php,phtml --ignore=./vendor/* .
Here is the list of issues, I've found:
report.txt
There are tones of PHPCompatibility.Miscellaneous.RemovedAlternativePHPTags.MaybeASPOpenTagFound: Possible use of ASP style opening tags detected. ASP style opening tags have been removed in PHP 7.0. Found errors which make report very noisy. I'm going to disable that rule for reported files and generate a new much more clear report

[sergeynezbritskiy]

After applying the PR #31913 the report is much more clear:
report.txt

[sivaschenko]

Thanks for the report @sergeynezbritskiy ! Added to the description

[m2-assistant]

Hi @andrewbess. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.4-develop branch

  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Add label Issue: Confirmed once verification is complete.

• 6. Make sure that automatic system confirms that report has been added to the backlog.