Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue] Fix unit tests with PHPUnit 9 errors #29329

Closed
4 tasks done
m2-assistant bot opened this issue Jul 30, 2020 · 1 comment · Fixed by #29244
Closed
4 tasks done

[Issue] Fix unit tests with PHPUnit 9 errors #29329

m2-assistant bot opened this issue Jul 30, 2020 · 1 comment · Fixed by #29244
Labels
Component: Captcha Component: Developer Component: Persistent Component: Pricing Component: Quote Component: Sales Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.

Comments

@m2-assistant
Copy link

m2-assistant bot commented Jul 30, 2020

This issue is automatically created based on existing pull request: #29244: Fix unit tests with PHPUnit 9 errors

Description (*)

Most of the failing tests are due to:

  • Depending on setUp logic in dataProviders, while dataProvider code is called before setUp
  • Trying to mock non-existing methods with createPartialMock which is prohibited in PHPUnit 9

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)
@AntonEvers AntonEvers mentioned this issue Jul 30, 2020
Merged
5 tasks
@magento-engcom-team magento-engcom-team added the Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed label Jul 30, 2020
@ghost ghost added Progress: PR in progress Priority: P3 May be fixed according to the position in the backlog. and removed Progress: ready for QA labels Jul 30, 2020
@slavvka
Copy link
Member

slavvka commented Aug 1, 2020

Hi @m2-assistant[bot]. Thank you for your report.
The issue has been fixed in #29244 by @AntonEvers in 2.4-develop branch
Related commit(s):

The fix will be available with the upcoming 2.4.1 release.

@slavvka slavvka added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label Aug 1, 2020
@slavvka slavvka closed this as completed Aug 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Captcha Component: Developer Component: Persistent Component: Pricing Component: Quote Component: Sales Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix unit tests with PHPUnit 9 errors AntonEvers/magento2
2 participants
@slavvka @magento-engcom-team