Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue] improve NonComposerComponentRegistration #29324

Closed
3 of 5 tasks
m2-assistant bot opened this issue Jul 29, 2020 · 0 comments
Closed
3 of 5 tasks

[Issue] improve NonComposerComponentRegistration #29324

m2-assistant bot opened this issue Jul 29, 2020 · 0 comments
Labels
Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”.

Comments

@m2-assistant
Copy link

m2-assistant bot commented Jul 29, 2020

This issue is automatically created based on existing pull request: #28975: improve NonComposerComponentRegistration

Description (*)

enable strict mode and added typeHint, this changes make execution of code more secure.
remove useless assignation $main.

Related Pull Requests

none

Fixed Issues

none

Manual testing scenarios (*)

not necessary, if CI passes this code is good, it's only technical improvement.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] improve NonComposerComponentRegistration #29308: improve NonComposerComponentRegistration
@m2-assistant m2-assistant bot added Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. labels Jul 29, 2020
@rvitaliy rvitaliy mentioned this issue Jul 29, 2020
Merged
5 tasks
@magento-engcom-team magento-engcom-team added the Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed label Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@VladimirZaets @magento-engcom-team