-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration Tests: DOM Assertion class #27607
Comments
Hi @lbajsarowicz. Thank you for your report.
Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:
For more details, please, review the Magento Contributor Assistant documentation. @lbajsarowicz do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?
|
✅ Confirmed by @sdzhepa Issue Available: @sdzhepa, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself. |
Still to be implemented. |
Hi @lbajsarowicz. Thank you for your report.
The fix will be available with the upcoming 2.4.0 release. |
The issue still needs to be implemented. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 14 days if no further activity occurs. Is this issue still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? Thank you for your contributions! |
Description (*)
We have plenty of integration tests that make assertions on HTML code:
With
assertContains
orpreg_match
. This is not the right approach for making assertions on HTML and the correct approach should be possible. The right approach is based on DOM tree.Example:
https://github.com/magento/magento2/pull/27606/files#diff-dcb208981e520970637c75ff2d89eafcR169-R173
Expected behavior (*)
We need the DOM assertion class to be introduced to Integration Tests Framework
Benefits
Additional information
The text was updated successfully, but these errors were encountered: