Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration Tests: DOM Assertion class #27607

Closed
lbajsarowicz opened this issue Apr 5, 2020 · 6 comments · Fixed by #27606
Closed

Integration Tests: DOM Assertion class #27607

lbajsarowicz opened this issue Apr 5, 2020 · 6 comments · Fixed by #27606
Labels
Component: Test feature request Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: ready for confirmation Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Progress: done Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. stale issue

Comments

@lbajsarowicz
Copy link
Contributor

lbajsarowicz commented Apr 5, 2020

Description (*)

We have plenty of integration tests that make assertions on HTML code:
image

With assertContains or preg_match. This is not the right approach for making assertions on HTML and the correct approach should be possible. The right approach is based on DOM tree.

Example:
https://github.com/magento/magento2/pull/27606/files#diff-dcb208981e520970637c75ff2d89eafcR169-R173

Expected behavior (*)

We need the DOM assertion class to be introduced to Integration Tests Framework

Benefits

Additional information

@m2-assistant
Copy link

m2-assistant bot commented Apr 5, 2020

Hi @lbajsarowicz. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

@lbajsarowicz do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Event: Global-Contribution-Day labels Apr 5, 2020
@lbajsarowicz lbajsarowicz linked a pull request Apr 5, 2020 that will close this issue
4 tasks
@sdzhepa sdzhepa added Component: Test Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Apr 5, 2020
@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Apr 5, 2020
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @sdzhepa
Thank you for verifying the issue. Based on the provided information internal tickets MC-33094 were created

Issue Available: @sdzhepa, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@lbajsarowicz
Copy link
Contributor Author

Still to be implemented.

@lbajsarowicz lbajsarowicz reopened this Apr 18, 2020
@ghost ghost removed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch labels Apr 18, 2020
@magento-engcom-team
Copy link
Contributor

Hi @lbajsarowicz. Thank you for your report.
The issue has been fixed in #27606 by @lbajsarowicz in 2.4-develop branch
Related commit(s):

The fix will be available with the upcoming 2.4.0 release.

@lbajsarowicz
Copy link
Contributor Author

The issue still needs to be implemented.
What is actually closed in scope of the PR mentioned above was use of such DOM assertions there.

@lbajsarowicz lbajsarowicz reopened this May 6, 2020
@ihor-sviziev ihor-sviziev added Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. and removed Event: Global-Contribution-Day labels Sep 29, 2020
@ghost ghost added Issue: ready for confirmation and removed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed labels Oct 21, 2020
@sivaschenko sivaschenko added the Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. label Nov 6, 2020
@stale
Copy link

stale bot commented Jan 21, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 14 days if no further activity occurs. Is this issue still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? Thank you for your contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Test feature request Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: ready for confirmation Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Progress: done Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. stale issue
Projects
Development

Successfully merging a pull request may close this issue.

6 participants