Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cms-page-specific layouts are not applied if FullActionName differs from page_view #26758

Closed
Tripuls-Magento opened this issue Feb 7, 2020 · 7 comments
Assignees
Labels
Component: Cms Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reported on 2.3.4 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@Tripuls-Magento
Copy link

Preconditions (*)

  1. magento 2.3.4
  2. create cms-specificlayout file in your module/theme for home

Steps to reproduce (*)

  1. Add a cms_page_view_selectable_home_somechanges.xml as described in https://devdocs.magento.com/guides/v2.3/frontend-dev-guide/layouts/xml-manage.html
  2. Edit the home page in the backend to use the specifc Layout (CMS->Pages->home>edit->design->select "somechanges" ..)
  3. Save.
  4. Clear layout-cache
  5. Refresh home page

Expected result (*)

  1. Specific layout changes from cms_page_view_selectable_home_somechanges.xml should be applied

Actual result (*)

  1. Changes have no effect

Workaraund:

Place a second file cms_index_index_selectable_home_somechanges.xml in your theme/module and the changes are applied.

Backgraund:

The DefaultLayoutHandle differs on the homepage from regular CMS_Page_View, since the full action name is cms_index_index
\Magento\Framework\View\Result\Page::addPageLayoutHandles
(\Magento\Framework\View\Result\Layout::getDefaultLayoutHandle)

@m2-assistant
Copy link

m2-assistant bot commented Feb 7, 2020

Hi @Tripuls-Magento. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

@Tripuls-Magento do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Feb 7, 2020
@engcom-Alfa engcom-Alfa self-assigned this Feb 11, 2020
@m2-assistant
Copy link

m2-assistant bot commented Feb 11, 2020

Hi @engcom-Alfa. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Alfa engcom-Alfa added Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Component: Cms Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Feb 11, 2020
@ghost ghost unassigned engcom-Alfa Feb 11, 2020
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @engcom-Alfa
Thank you for verifying the issue. Based on the provided information internal tickets MC-31374 were created

Issue Available: @engcom-Alfa, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Feb 11, 2020
@IbrahimS2
Copy link

@Tripuls-Magento I just had this issue, and thank god you outlined the workaround :D

Thank you.

@sergiy-v sergiy-v self-assigned this Mar 2, 2020
@m2-assistant
Copy link

m2-assistant bot commented Mar 2, 2020

Hi @sergiy-v. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. If the issue is not relevant or is not reproducible any more, feel free to close it.


@magento-engcom-team
Copy link
Contributor

Hi @Tripuls-Magento. Thank you for your report.
The issue has been fixed in #27131 by @sergiy-v in 2.4-develop branch
Related commit(s):

The fix will be available with the upcoming 2.4.0 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label Mar 12, 2020
@magento-engcom-team magento-engcom-team added the Reported on 2.3.4 Indicates original Magento version for the Issue report. label Nov 13, 2020
@IbrahimS2
Copy link

@magento-engcom-team Why this still a problem in 2.3.6?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Cms Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reported on 2.3.4 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
None yet
Development

No branches or pull requests

5 participants