-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Layered navigation breaks HTML5 Validation #22363
Comments
Hi @ioweb-gr. Thank you for your report.
Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:
For more details, please, review the Magento Contributor Assistant documentation. @ioweb-gr do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?
|
@magento-engcom-team give me 2.3-develop instance |
Hi @ioweb-gr. Thank you for your request. I'm working on Magento 2.3-develop instance for you |
Hi @ioweb-gr, here is your Magento instance. |
Is it possible to receive a Magento instance with sample data installed? This one is empty. |
Hi @engcom-backlog-nazar. Thank you for working on this issue.
|
✅ Confirmed by @engcom-backlog-nazar Issue Available: @engcom-backlog-nazar, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself. |
Hi @niravkrish. Thank you for working on this issue.
|
HI @ioweb-gr, Thanks for your reporting and collaboration. We have verified the issue in Latest 2.4-develop instance and the issue is reproducible.Kindly refer the screenshots. Steps to reproduce
There are multiple errors related to attributes. Hence Confirming the issue. Thanks. |
✅ Jira issue https://jira.corp.adobe.com/browse/AC-11933 is successfully created for this GitHub issue. |
✅ Confirmed by @engcom-Bravo. Thank you for verifying the issue. |
❌ Cannot export the issue. This GitHub issue is already linked to Jira issue(s): https://jira.corp.adobe.com/browse/AC-11933 |
Preconditions (*)
Steps to reproduce (*)
Expected result (*)
Validation passes with warnings only and no errors.
Actual result (*)
Multiple html5 errors due to layered navigaton
etc etc
According to the specification custom attributes should be prefixed via
data-
For example it would be proper to say
data-option-type="..."
butoption-type="..."
is invalid.https://www.w3schools.com/tags/att_global_data.asp
The text was updated successfully, but these errors were encountered: