Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quality drops and transparency replaced with solid color when uploading .png with transparent background #10343

Closed
MichaelJamesParsons opened this issue Jul 27, 2017 · 7 comments
Labels
Fixed in 2.1.x The issue has been fixed in 2.1 release line Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed

Comments

@MichaelJamesParsons
Copy link

Preconditions

  1. Magento 2.1.7
  2. PHP 7.1

Steps to reproduce

  1. Navigate to "add new CMS page" view of the admin panel
  2. Using the WYSIWYG editor, click "insert/edit image"
  3. Click the "browse" button
  4. Upload an image with colored text over a transparent background
  5. Insert the image and save

Expected result

  1. The image should be inserted into the CMS page without any loss in quality, and should keep a transparent background.

Actual result

  1. The image is inserted into the CMS page, but there is a very noticeable loss in quality (the colored portions of the image look rough). All transparent layers are replaced with solid black.
Original Transparent Image

28398027-c9dd62a8-6cca-11e7-8354-6368d691c4a7

Post-Upload Image

28398006-ad37aad2-6cca-11e7-89ff-528df066bb88

Related Issues

#5401
#2312

Attempts to fix

#7307

@orlangur
Copy link
Contributor

Did mentioned fix solve your problem in develop after all?

@MichaelJamesParsons
Copy link
Author

@orlangur Version 2.1.7 does not include the fix.

Magento 2.1.7

Gd2.php Line 349
ImageMagick.php Line 171

vs

Development

Gd2.php Line 349
ImageMagick.php Line 171

I am hesitant to use the dev branch in production. Are there any plans in the near future to include that fix in 2.1.*?

@orlangur
Copy link
Contributor

@MichaelJamesParsons, yeah, that's why I was asking about develop branch.

The fix was backported to 2.1.x in #9662 and will be released in 2.1.8 😉

@orlangur orlangur added the 2.1.x label Jul 28, 2017
@MichaelJamesParsons
Copy link
Author

@orlangur Is there an official release date for 2.1.8?

@orlangur
Copy link
Contributor

Yesterday :)

@magento-engcom-team magento-engcom-team added 2.1.x Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed and removed G1 Passed labels Sep 5, 2017
@magento-engcom-team magento-engcom-team added Fixed in 2.1.x The issue has been fixed in 2.1 release line Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line labels Sep 26, 2017
@magento-engcom-team
Copy link
Contributor

@MichaelJamesParsons, thank you for your report.
The fix for this issue is already available in the 2.1, 2.2 and develop branches.

@artskeem
Copy link

Magento 2.2 is having the same problems - using a fresh install with no errors - and using image magic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed in 2.1.x The issue has been fixed in 2.1 release line Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed
Projects
None yet
Development

No branches or pull requests

4 participants