-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong order of "width" x "height" when uploading image to admin under Content>Design Config #10124
Comments
Exactly same problem on Magento CE 2.1.7. How did you change the code? How it should be according to the image above? Thanks, |
@mjoraid I created Pull Request based on your investigation. I think it will be processed faster than this issue. |
@alstenconsuilting to answer your question:
Go to this Javascript file:
and switch the order of the code at line 361 & 362. Instead of height = width, make sure it's height = height and width = width. But in the code is that it's mixed up, it's set to width = height and height = width. Wrong Code:
Correct Code:
I'm still failry new to Github, but it seems @ihor-sviziev has made a pull request to add the code to the offical implementation. |
@mjoraid . Thank you. I changed code exactly as you described and it worked. Thanks again, |
Internal ticket to track issue progress: MAGETWO-70419 |
@mjoraid, thank you for your report. |
Preconditions
Steps to reproduce
Expected result
Actual result
The issue is within the file "file-uploader.js" having width and height mixed up in wrong order.
Source File:
<magento root>/vendor/magento/module-ui/view/base/web/js/form/element/file-uploader.js
The text was updated successfully, but these errors were encountered: