From cad441e64af84a5841c418c1b5455417646cdb32 Mon Sep 17 00:00:00 2001 From: Oleksandr Gorkun Date: Tue, 21 May 2019 18:05:00 -0500 Subject: [PATCH 1/3] MAGETWO-56445: Eliminate @escapeNotVerified in Google-related Modules --- .../view/frontend/templates/code.phtml | 18 +++++++++--------- .../view/frontend/templates/ga.phtml | 6 +++--- 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/app/code/Magento/GoogleAdwords/view/frontend/templates/code.phtml b/app/code/Magento/GoogleAdwords/view/frontend/templates/code.phtml index 7daad72994b00..6e54ee5f69000 100644 --- a/app/code/Magento/GoogleAdwords/view/frontend/templates/code.phtml +++ b/app/code/Magento/GoogleAdwords/view/frontend/templates/code.phtml @@ -12,22 +12,22 @@ - + diff --git a/app/code/Magento/GoogleAnalytics/view/frontend/templates/ga.phtml b/app/code/Magento/GoogleAnalytics/view/frontend/templates/ga.phtml index ed8c0e3fe3cc8..f5cc9f09a55ed 100644 --- a/app/code/Magento/GoogleAnalytics/view/frontend/templates/ga.phtml +++ b/app/code/Magento/GoogleAnalytics/view/frontend/templates/ga.phtml @@ -16,9 +16,9 @@ "Magento_GoogleAnalytics/js/google-analytics": { "isCookieRestrictionModeEnabled": isCookieRestrictionModeEnabled() ?>, "currentWebsite": getCurrentWebsiteId() ?>, - "cookieName": "", - "ordersTrackingData": getOrdersTrackingData()) ?>, - "pageTrackingData": getPageTrackingData($accountId)) ?> + "cookieName": "", + "ordersTrackingData": getOrdersTrackingData()) ?>, + "pageTrackingData": getPageTrackingData($accountId)) ?> } } } From 53b66f194c9ddf041940e335dcb0f6ddf32f355e Mon Sep 17 00:00:00 2001 From: Oleksandr Gorkun Date: Thu, 23 May 2019 16:49:12 -0500 Subject: [PATCH 2/3] MAGETWO-56445: Eliminate @escapeNotVerified in Google-related Modules --- .../Magento/GoogleAdwords/view/frontend/templates/code.phtml | 2 -- .../Magento/GoogleAnalytics/view/frontend/templates/ga.phtml | 3 --- 2 files changed, 5 deletions(-) diff --git a/app/code/Magento/GoogleAdwords/view/frontend/templates/code.phtml b/app/code/Magento/GoogleAdwords/view/frontend/templates/code.phtml index 6e54ee5f69000..c9076b637150e 100644 --- a/app/code/Magento/GoogleAdwords/view/frontend/templates/code.phtml +++ b/app/code/Magento/GoogleAdwords/view/frontend/templates/code.phtml @@ -3,8 +3,6 @@ * Copyright © Magento, Inc. All rights reserved. * See COPYING.txt for license details. */ - -// @codingStandardsIgnoreFile ?> getConfig(\Magento\GoogleAnalytics\Helper\Data::XML_PATH_ACCOUNT) ?> From 32aa8a2afef5f4ef76c1e02a4ffed49bc64cb3bb Mon Sep 17 00:00:00 2001 From: Oleksandr Gorkun Date: Fri, 24 May 2019 11:21:32 -0500 Subject: [PATCH 3/3] MAGETWO-56445: Eliminate @escapeNotVerified in Google-related Modules --- .../Magento/GoogleAdwords/view/frontend/templates/code.phtml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/code/Magento/GoogleAdwords/view/frontend/templates/code.phtml b/app/code/Magento/GoogleAdwords/view/frontend/templates/code.phtml index c9076b637150e..e3c46bc27834c 100644 --- a/app/code/Magento/GoogleAdwords/view/frontend/templates/code.phtml +++ b/app/code/Magento/GoogleAdwords/view/frontend/templates/code.phtml @@ -16,7 +16,7 @@ var google_conversion_color = "escapeJs($block->getHelper()->getConversionColor()) ?>"; var google_conversion_label = "escapeJs($block->getHelper()->getConversionLabel()) ?>"; var google_conversion_value = escapeJs($block->getHelper()->getConversionValue()) ?>; - getHelper()->hasSendConversionValueCurrency() && $block->getHelper()->getConversionValueCurrency()): ?> + getHelper()->hasSendConversionValueCurrency() && $block->getHelper()->getConversionValueCurrency()) : ?> var google_conversion_currency = "escapeJs($block->getHelper()->getConversionValueCurrency()) ?>"; /* ]]> */