Skip to content
This repository has been archived by the owner on Dec 19, 2019. It is now read-only.

[Place order] Cart tax #426

Closed
naydav opened this issue Mar 4, 2019 · 2 comments
Closed

[Place order] Cart tax #426

naydav opened this issue Mar 4, 2019 · 2 comments
Assignees
Labels
Contribution Day Tickets is good for start on Contribution Day good first issue Good for newcomers

Comments

@naydav
Copy link
Contributor

naydav commented Mar 4, 2019

Implement "cart tax" according to proposed scheme
https://github.com/magento/architecture/blob/master/design-documents/graph-ql/coverage/CartPrices.graphqls

The scheme could be changed

Functionality should be covered by API-functional tests

Also, need to check the case described in
#411

@naydav naydav added the Contribution Day Tickets is good for start on Contribution Day label Mar 4, 2019
@naydav naydav added this to the Release: 2.3.2 milestone Mar 4, 2019
@naydav naydav added the good first issue Good for newcomers label Mar 4, 2019
@rogyar rogyar assigned rogyar and unassigned rogyar Mar 4, 2019
@XxXgeoXxX XxXgeoXxX self-assigned this Mar 5, 2019
@rogyar
Copy link
Contributor

rogyar commented Mar 5, 2019

Hi @XxXgeoXxX. I'm accidentally unassigned myself. I'm working on that solution alongside the cart grand total. There's might be just one resolver, so no reason to have a few separate PRs.

@rogyar rogyar self-assigned this Mar 5, 2019
@XxXgeoXxX XxXgeoXxX removed their assignment Mar 5, 2019
@naydav
Copy link
Contributor Author

naydav commented Apr 16, 2019

#441

@naydav naydav closed this as completed Apr 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Contribution Day Tickets is good for start on Contribution Day good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants