Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support of PNG IPTC reading to MediaGalleryMetadata module implementation #1553

Closed
sivaschenko opened this issue Jul 2, 2020 · 2 comments · Fixed by #1675
Closed

Add support of PNG IPTC reading to MediaGalleryMetadata module implementation #1553

sivaschenko opened this issue Jul 2, 2020 · 2 comments · Fixed by #1675
Assignees
@Nazar65
Labels
Backend Complex Priority: P1 Needs to be fixed before any other issues Progress: done Severity: S2 Affects non-critical data or functionality and forces users to employ a workaround
Milestone
2.1.0

Comments

@sivaschenko
Copy link
Member

sivaschenko commented Jul 2, 2020 •
edited by lenaorobei
Loading

Add support of GIF XMP readingto MediaGalleryMetadat module implementation.

Technical Design:
https://github.com/magento/adobe-stock-integration/wiki/Technical-Design:-Images-metadata-processing

What needs to be done:

  • Introduce Magento\MediaGalleryMetadata\Model\Png\Segment\IptcReader(see examples of implementation in Png and Jpeg namespaces)
  • Add the png image containing only IPTC data to Magento\MediaGalleryMetadata\Test\Integration\Model\ExtractMetadataTest integration test
  • Cover the implementation with Magento\MediaGalleryMetadata\Test\Integration\Model\AddIptcMetadataTest integration test (should be the same as Magento\MediaGalleryMetadata\Test\Integration\Model\AddIptcMetadataTest however the Magento\MediaGalleryMetadataApi\Api\AddMetadataInterface instance used should be configured to use only Iptc writer)
@sivaschenko sivaschenko added Backend Complex Priority: P1 Needs to be fixed before any other issues labels Jul 2, 2020
@sivaschenko sivaschenko added this to the 2.1.0 milestone Jul 2, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jul 2, 2020

Hi @sivaschenko. Thank you for your report.
To help us process this issue please make sure that you provided sufficient information.

Please, add a comment to assign the issue: @magento I am working on this

@sivaschenko sivaschenko added Priority: P2 Should be fixed as early as possible and removed Priority: P1 Needs to be fixed before any other issues Progress: ready for dev labels Jul 2, 2020
@sivaschenko sivaschenko changed the title Add support of PNG IPTC writing to MediaGalleryMetadata module implementation Add support of PNG IPTC reading/writing to MediaGalleryMetadata module implementation Jul 2, 2020
@Nazar65 Nazar65 self-assigned this Jul 17, 2020
@Nazar65 Nazar65 removed their assignment Jul 17, 2020
@yolouiese
Copy link
Contributor

@magento I am working on this

@yolouiese yolouiese removed their assignment Jul 21, 2020
@Nazar65 Nazar65 self-assigned this Jul 21, 2020
@lenaorobei lenaorobei changed the title Add support of PNG IPTC reading/writing to MediaGalleryMetadata module implementation Add support of PNG IPTC reading to MediaGalleryMetadata module implementation Jul 28, 2020
@sivaschenko sivaschenko added Priority: P1 Needs to be fixed before any other issues Severity: S2 Affects non-critical data or functionality and forces users to employ a workaround and removed Priority: P2 Should be fixed as early as possible labels Jul 29, 2020
@Nazar65 Nazar65 mentioned this issue Jul 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Nazar65 Nazar65

Labels
Backend Complex Priority: P1 Needs to be fixed before any other issues Progress: done Severity: S2 Affects non-critical data or functionality and forces users to employ a workaround
Projects
None yet
Milestone
2.1.0
Development

Successfully merging a pull request may close this issue.

Add support of PNG IPTC reading && writing to MediaGalleryMetadata module implementation
3 participants
@sivaschenko @Nazar65 @yolouiese