There has to be a separate refactor for effects that distribute among targets

[Alex-Vasile]

I think this can be merged as is but there probably has to be a separate refactor for effects that distribute among targets

Originally posted by @theelk801 in #9408 (comment)

[Cguy7777]

I'm going to start working on this.

Here, Susucre proposed creating a new target class TargetUpToCreaturePermanentAmount, which I'm thinking might be the best approach.

[xenohedron]

I don't think I like that approach.

The TargetAmount classes are already a bit unwieldy as it is due to the way filters are structured:

Adding another parameter by separate classes will not be a good inheritance structure.

It may be better to force devs to define all the relevant constructor parameters, such that the base constructor in TargetAmount has a signature of (DynamicValue amount, int minNumberOfTargets, int maxNumberOfTargets) like standard target classes and all the others chain from that (applying appropriate defaults where params can be safely omitted)

Another point - the amount param should be removed from the effect classes and the text generation can take it from the TargetAmount instead, to reduce duplication. (Makes sense to check instanceof TargetAmount anyway.)

Thoughts?

[Cguy7777]

That sounds like a better approach. I'll start with that idea and see how it works.