Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should use path.sep instead of / for cross-OS compat #7

Open
blahah opened this issue May 4, 2017 · 1 comment
Open

should use path.sep instead of / for cross-OS compat #7

blahah opened this issue May 4, 2017 · 1 comment

Comments

@blahah
Copy link

blahah commented May 4, 2017

Right now paths are created using / to join and split paths - this makes the library not compatible with node fs on Windows. If all the / path construction and parsing was changed to use path.sep, it would be OS tolerant I think.

@martinheidegger
Copy link

It might be a good idea to turn / into a constant (for code-reading-sake) but the purpose of the append-tree API is that system-independent logs are written and this separator really is a "append-tree" separator; not-os-specific. Any API that uses append-tree to create folders should be doing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants