This repository has been archived by the owner on Feb 21, 2020. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes all started as I wanted to install sonar from OS packages (RPMs on EL7, specifically).
In simple terms, I've added a parameter
use_packages
which isfalse
by default. If settrue
, the module will install sonarqube from an OS package. Iffalse
, it will use your code to install from source.I've also updated the test configuration to work on later versions of puppet + ruby, and use rspec-puppet-facts.
I'm submitting this as a PR not because it's ready to accept, but so you get some visibility and can offer feedback :)
Individual commit messages: