Skip to content

Commit

Permalink
[vs tests] Mark VLAN and warm reboot tests as xfail (sonic-net#1183)
Browse files Browse the repository at this point in the history
Signed-off-by: Danny Allen <[email protected]>
  • Loading branch information
daall authored and lguohan committed Jan 30, 2020
1 parent da89cf2 commit 6b4b6ef
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 0 deletions.
8 changes: 8 additions & 0 deletions tests/test_vlan.py
Original file line number Diff line number Diff line change
Expand Up @@ -424,6 +424,10 @@ def test_AddVlanWithIncorrectValueType(self, dvs, testlog, test_input, expected)
#remove vlan
dvs.remove_vlan(vlan)

# FIXME: This test is extremely unstable and requires several retries
# for it to pass - we need to stabilize this test before putting it back
# into the pipeline.
@pytest.mark.xfail(reason="test case is unstable")
def test_AddPortChannelToVlan(self, dvs, testlog):
self.setup_db(dvs)
marker = dvs.add_log_marker()
Expand Down Expand Up @@ -644,6 +648,10 @@ def test_AddMaxVlan(self, dvs, testlog):
vlan_entries = [k for k in tbl.getKeys() if k != dvs.asicdb.default_vlan_id]
assert len(vlan_entries) == 0

# FIXME: This test is extremely unstable and requires several retries
# for it to pass - we need to stabilize this test before putting it back
# into the pipeline.
@pytest.mark.xfail(reason="test case is unstable")
def test_RemoveVlanWithRouterInterface(self, dvs, testlog):
dvs.setup_db()
marker = dvs.add_log_marker()
Expand Down
5 changes: 5 additions & 0 deletions tests/test_warm_reboot.py
Original file line number Diff line number Diff line change
Expand Up @@ -234,6 +234,7 @@ def ping_new_ips(dvs):
dvs.runcmd(['sh', '-c', "ping -c 1 -W 0 -q {}.0.0.{} > /dev/null 2>&1".format(i*4,j+NUM_NEIGH_PER_INTF+2)])
dvs.runcmd(['sh', '-c', "ping6 -c 1 -W 0 -q {}00::{} > /dev/null 2>&1".format(i*4,j+NUM_NEIGH_PER_INTF+2)])


class TestWarmReboot(object):
def test_PortSyncdWarmRestart(self, dvs, testlog):

Expand Down Expand Up @@ -1794,6 +1795,10 @@ def test_routing_WarmRestart(self, dvs, testlog):
intf_tbl._del("{}".format(intfs[2]))
time.sleep(2)

# FIXME: This test is extremely unstable and requires several retries
# for it to pass - we need to stabilize this test before putting it back
# into the pipeline.
@pytest.mark.xfail(reason="test case is unstable")
def test_system_warmreboot_neighbor_syncup(self, dvs, testlog):

appl_db = swsscommon.DBConnector(swsscommon.APPL_DB, dvs.redis_sock, 0)
Expand Down

0 comments on commit 6b4b6ef

Please sign in to comment.