Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support IPs as well #8

Closed
jkroepke opened this issue Apr 5, 2024 · 1 comment · Fixed by #11
Closed

Support IPs as well #8

jkroepke opened this issue Apr 5, 2024 · 1 comment · Fixed by #11
Assignees

Comments

@jkroepke
Copy link

jkroepke commented Apr 5, 2024

In my tests, I would like to connect to 127.0.0.1, but its fails

tls: failed to verify certificate: x509: cannot validate certificate for 127.0.0.1 because it doesn't contain any IP SANs

Currently, ca.NewKeyPair only supports domains, but no IPs.

Would it be possible to add 127.0.0.1 and ::1 by default? The x509.Certificate has a dedicated field for IPAddresses

@madflojo
Copy link
Owner

Hi @jkroepke,

I must have missed the notification for this. That's a great suggestion; I'll look into the best way to add the ability to specify IP addresses.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants