-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set helm releases history size. #44
Conversation
Helm keeps releases history as k8s secrets. If we don't set max_history it will be unlimited. There is an opened issue related to that helm/helm#7997. If count of secrets is huge then helm list/istall can be failed due to: ``` request.go:924] Unexpected error when reading response body: net/http: request canceled (Client.Timeout exceeded while reading body) Error: unable to build kubernetes objects from release manifest: unexpected error when reading response body. Please retry. Original error: net/http: request canceled (Client.Timeout exceeded while reading body ```
@mglotov wouldn't it better to set this limit using variable? |
|
@halfb00t Do you want to set them as we do for helm chart version? |
@p1gmale0n @halfb00t hmm, is it really OK to have one variable for all releases? |
i think this is ok for as the default behavior. |
…to store instead of hardcoding the value.
Does it cover failed releases? In helm/helm#7997 (comment) we ended with lots of release versions due to a deployment bug that went for few weeks. We had a loop deploying helm releases that always failed (failure unrelated to helm), then retried... So we had thousands of failed versions. |
Yes, it does. It covers all release versions (failed, deployed, ..). There are some changes in helm v3.5.3 and terraform-helm-provider v2.1.1. Starting from those if you don't have at least one deployed release, then you are limited by max_history size and can't deploy any new release version, even if it's a working release version. You will need to increase max_history value or delete a k8s secret with the release version. |
Helm keeps releases history as k8s secrets. If we don't set max_history it will be unlimited.
There is an opened issue related to that helm/helm#7997.
If count of secrets is huge then helm list/istall can be failed due to: