Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(imports): many imports do not inherit from workspace #412

Open
1 task done
Tracked by #413
Trantorian1 opened this issue Dec 10, 2024 · 0 comments
Open
1 task done
Tracked by #413

fix(imports): many imports do not inherit from workspace #412

Trantorian1 opened this issue Dec 10, 2024 · 0 comments
Labels
code-quality Improvements to code structure and quality

Comments

@Trantorian1
Copy link
Collaborator

Is there an existing issue?

  • I have searched the existing issues

Motivation

A lot of imports throughout the many crates in Madara do not share a common source at the workspace level.

This is an issue as it can lead to the same dependency being used in several crates but with a different version. It also makes it harder to reason about what our actual dependencies are.

Request

Remove crate-level imports.

Solution

Refactor crate-specific imports to inherit all their dependencies from the workspace. This is a manual effort and requires sifting through every Cargo.toml file individually.

It might also be a good idea to run cargo machette while we're at it to try and remove any unused dependecies.

Are you willing to help with this request?

Yes

@Trantorian1 Trantorian1 added the code-quality Improvements to code structure and quality label Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-quality Improvements to code structure and quality
Projects
Status: No status
Development

No branches or pull requests

1 participant