Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(devnet): incorrect error message when chain id isn't devnet #302

Closed
1 task done
Tracked by #419
apoorvsadana opened this issue Oct 2, 2024 · 0 comments · Fixed by #448
Closed
1 task done
Tracked by #419

bug(devnet): incorrect error message when chain id isn't devnet #302

apoorvsadana opened this issue Oct 2, 2024 · 0 comments · Fixed by #448
Labels
bug Report an issue or unexpected behavior

Comments

@apoorvsadana
Copy link
Contributor

Is there an existing issue?

  • I have searched the existing issues

Description of bug

Currently in the check here we throw an error if the user is using --devnet but the chain id isn't devnet. We should instead only throw an error if the chain id is SN_SEPOLIA or SN_MAINNET. Or we can also consider removing the error completely but changing the default chain id to not SN_SEPOLIA or SN_MAINNET.

Steps to reproduce

No response
@antiyro antiyro added this to Madara Oct 8, 2024
@Trantorian1 Trantorian1 added the bug Report an issue or unexpected behavior label Dec 10, 2024
@Trantorian1 Trantorian1 mentioned this issue Dec 10, 2024
Open
12 tasks
@Trantorian1 Trantorian1 changed the title bug: incorrect error message when chain id isn't devnet bug(devnet): incorrect error message when chain id isn't devnet Dec 11, 2024
This was referenced Dec 30, 2024
Open
Merged
@github-project-automation github-project-automation bot moved this to Done in Madara Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Report an issue or unexpected behavior
Projects
Madara
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(devnet): loosened devnet chain id restrictions madara-alliance/madara
2 participants
@apoorvsadana @Trantorian1