feat : added nominate functions and starknet core contract types #6
Conversation
| use crate::contract_clients::starknet_validity::StarknetValidityContract; | ||
| use crate::utils::convert_felt_to_u256; | ||
|
|
||
| pub enum CoreContractStarknetL1Enum { |
There was a problem hiding this comment.
Do we really need this enum? Can we not implement trait CoreContract for StarknetSovereignContract and StarknetValidityContract and when we call those methods we call them with Box<dyn CoreContract>
There was a problem hiding this comment.
can you give an example of this ? I didn't get it I added dyn CoreContract wherever required.
There was a problem hiding this comment.
was this fixed, looks like it was
| use crate::CliArgs; | ||
|
|
||
| pub struct CoreContractStarknetL1<'a> { | ||
| arg_config: &'a CliArgs, |
There was a problem hiding this comment.
this should be only the relevant args needed
There was a problem hiding this comment.
clippy suggested it so I added otherwise it was giving the errors
There was a problem hiding this comment.
what I mean is that we shouldn't pass the entire struct CliArgs because it has a lot of irrelevant stuff. we just need to pass those fields which are needed.
| @@ -82,5 +82,7 @@ fn get_config() -> CliArgs { | |||
| l1_multisig_address: String::from(L1_MULTISIG_ADDRESS), | |||
| l2_multisig_address: String::from(L2_MULTISIG_ADDRESS), | |||
| verifier_address: String::from(VERIFIER_ADDRESS), | |||
| operator_address: String::from(OPERATOR_ADDRESS), | |||
| dev: true, | |||
There was a problem hiding this comment.
can we test without dev as well?
There was a problem hiding this comment.
can we test without dev flag?
To run in dev mode :