Mapping func/subxt #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ocdbytes
commented
Jun 10, 2024
ocdbytes
commented
- added genesis state declarations.
- updated with declareV0 call.
- updated the tests.
added 2 commits
June 10, 2024 18:22
Readme.md
Outdated
| the **Token Bridge** & **Eth Bridge** contract | ||
| between a madara/katana appchain and | ||
| another L2 or L1 network. It will also declare wallet | ||
| contracts from **OpenZappeline**, **Argent** and |
There was a problem hiding this comment.
Suggested change
| contracts from **OpenZappeline**, **Argent** and | |
| contracts from **OpenZeppelin**, **Argent** and |
src/contract_clients/subxt_funcs.rs
Outdated
src/contract_clients/init_state.rs
Outdated
There was a problem hiding this comment.
let's remove this file and break it to smaller parts as discusssed
src/contract_clients/token_bridge.rs
Outdated
|
|
||
| let deploy_tx = account | ||
|
|
||
| let token_bridge_class_hash = declare_contract_middleware(DeclarationInput::DeclarationInputs( |
There was a problem hiding this comment.
this isn't really a middleware, more like a util
src/utils/mapper.rs
Outdated
Readme.md
Outdated
Comment on lines
3
to
9
| Madara Bootstarp is a tool that helps to deploy | ||
| the **Token Bridge** & **Eth Bridge** contract | ||
| between a madara/katana appchain and | ||
| another L2 or L1 network. It will also declare wallet | ||
| contracts from **OpenZappelin**, **Argent** and | ||
| **Braavos**. You can find the full list of contracts | ||
| in [Info](#info-ℹ) |
There was a problem hiding this comment.
the number of words per line seem to be very low no?
Readme.md
Outdated
| the **Token Bridge** & **Eth Bridge** contract | ||
| between a madara/katana appchain and | ||
| another L2 or L1 network. It will also declare wallet | ||
| contracts from **OpenZappeline**, **Argent** and |
src/bridge/deploy_eth_bridge.rs
Outdated
| save_to_json("l2_eth_address", &JsonValueType::StringType(eth_address.to_string()))?; | ||
| log::info!("L2 ETH Token Deployment Successful [✅]"); | ||
| log::info!("[🚀] L2 ETH Token Address : {:?}", eth_address); | ||
| // save_to_json("l2_eth_address", &JsonValueType::StringType(eth_address.to_string()))?; |
There was a problem hiding this comment.
does this need to be commented?
src/main.rs
Outdated
| pub l2_erc20_token_address: FieldElement, | ||
| } | ||
|
|
||
| pub async fn deploy_bridges(config: &CliArgs) -> DeployBridgeOutput { |
There was a problem hiding this comment.
Suggested change
| pub async fn deploy_bridges(config: &CliArgs) -> DeployBridgeOutput { | |
| pub async fn bootstrap(config: &CliArgs) -> DeployBridgeOutput { |
.github/workflows/linters.yml
Outdated
Comment on lines
17
to
25
| # markdown-lint: | ||
| # runs-on: ubuntu-latest | ||
| # steps: | ||
| # - uses: actions/checkout@v3 | ||
| # - uses: avto-dev/markdown-lint@v1 | ||
| # with: | ||
| # config: "./.markdownlint.json" | ||
| # args: "." | ||
| # ignore: "./target" |
There was a problem hiding this comment.
let's uncomment this?
src/contract_clients/utils.rs
Outdated
| rpc, | ||
| signer, | ||
| account_address, | ||
| FieldElement::from_hex_be("0x4d4144415241").unwrap(), |
There was a problem hiding this comment.
we shouldn't hardcode this
src/contract_clients/utils.rs
Outdated
| } | ||
|
|
||
| #[allow(private_interfaces)] | ||
| pub async fn declare_contract_util_func(input: DeclarationInput<'_>) -> FieldElement { |
There was a problem hiding this comment.
Suggested change
| pub async fn declare_contract_util_func(input: DeclarationInput<'_>) -> FieldElement { | |
| pub async fn declare_contract(input: DeclarationInput<'_>) -> FieldElement { |
src/setup_scripts/account_setup.rs
Outdated
| use crate::utils::{convert_to_hex, save_to_json, JsonValueType}; | ||
| use crate::CliArgs; | ||
|
|
||
| pub async fn account_init_func<'a>(clients: &'a Config, arg_config: &'a CliArgs) -> RpcAccount<'a> { |
There was a problem hiding this comment.
Suggested change
| pub async fn account_init_func<'a>(clients: &'a Config, arg_config: &'a CliArgs) -> RpcAccount<'a> { | |
| pub async fn account_init<'a>(clients: &'a Config, arg_config: &'a CliArgs) -> RpcAccount<'a> { |
| let braavos_class_hash = declare_contract_util_func(DeclarationInput::DeclarationInputs( | ||
| String::from(BRAAVOS_ACCOUNT_SIERRA_PATH), | ||
| String::from(BRAAVOS_ACCOUNT_CASM_PATH), | ||
| self.account.clone(), |
There was a problem hiding this comment.
do we need to clone, can we pass a ref?
There was a problem hiding this comment.
we can't gives error. If it would be possible clippy me aa jaega
added 2 commits
June 12, 2024 00:47
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.