-
-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix MacosPulldownMenuItem.onTap
doesn't open alert dialog
#520
Fix MacosPulldownMenuItem.onTap
doesn't open alert dialog
#520
Conversation
40771dd
to
15526d6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @TahaTesser !!! Just one small change request and then we are good to go
lib/src/buttons/pulldown_button.dart
Outdated
@@ -65,8 +65,8 @@ class _MacosPulldownMenuItemButtonState | |||
final MacosPulldownMenuEntry menuEntity = | |||
widget.route.items[widget.itemIndex].item!; | |||
if (menuEntity is MacosPulldownMenuItem) { | |||
menuEntity.onTap?.call(); | |||
Navigator.pop(context); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we make this .of(context).pop()
please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
Just gonna run the checks manually since you're a first time contributor |
Looks like we've got some failing tests |
4a44177
to
1b0dd59
Compare
For some reason test passes locally with FlutterLogo but not in the CI so i just replaced it. |
fixes MacosPulldownMenuItem onTap doesnt call showMacosAlertDialog
Code sample
expand to view the code sample
Preview
Pre-launch Checklist
CHANGELOG.md
with my changes